Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/devtools/devtools_window.h

Issue 2983533002: Revert of Provide WebContents::CreateParams to tab helpers. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h" 9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
10 #include "chrome/browser/devtools/devtools_toggle_action.h" 10 #include "chrome/browser/devtools/devtools_toggle_action.h"
11 #include "chrome/browser/devtools/devtools_ui_bindings.h" 11 #include "chrome/browser/devtools/devtools_ui_bindings.h"
12 #include "content/public/browser/web_contents.h"
13 #include "content/public/browser/web_contents_delegate.h" 12 #include "content/public/browser/web_contents_delegate.h"
14 #include "content/public/browser/web_contents_observer.h" 13 #include "content/public/browser/web_contents_observer.h"
15 14
16 class Browser; 15 class Browser;
17 class BrowserWindow; 16 class BrowserWindow;
18 class DevToolsWindowTesting; 17 class DevToolsWindowTesting;
19 class DevToolsEventForwarder; 18 class DevToolsEventForwarder;
20 class DevToolsEyeDropper; 19 class DevToolsEyeDropper;
21 20
22 namespace content { 21 namespace content {
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 const std::string& settings); 281 const std::string& settings);
283 282
284 // content::WebContentsDelegate: 283 // content::WebContentsDelegate:
285 void ActivateContents(content::WebContents* contents) override; 284 void ActivateContents(content::WebContents* contents) override;
286 void AddNewContents(content::WebContents* source, 285 void AddNewContents(content::WebContents* source,
287 content::WebContents* new_contents, 286 content::WebContents* new_contents,
288 WindowOpenDisposition disposition, 287 WindowOpenDisposition disposition,
289 const gfx::Rect& initial_rect, 288 const gfx::Rect& initial_rect,
290 bool user_gesture, 289 bool user_gesture,
291 bool* was_blocked) override; 290 bool* was_blocked) override;
292 void WebContentsCreated( 291 void WebContentsCreated(content::WebContents* source_contents,
293 content::WebContents* source_contents, 292 int opener_render_process_id,
294 int opener_render_process_id, 293 int opener_render_frame_id,
295 int opener_render_frame_id, 294 const std::string& frame_name,
296 const std::string& frame_name, 295 const GURL& target_url,
297 const GURL& target_url, 296 content::WebContents* new_contents) override;
298 content::WebContents* new_contents,
299 const base::Optional<content::WebContents::CreateParams>& create_params)
300 override;
301 void CloseContents(content::WebContents* source) override; 297 void CloseContents(content::WebContents* source) override;
302 void ContentsZoomChange(bool zoom_in) override; 298 void ContentsZoomChange(bool zoom_in) override;
303 void BeforeUnloadFired(content::WebContents* tab, 299 void BeforeUnloadFired(content::WebContents* tab,
304 bool proceed, 300 bool proceed,
305 bool* proceed_to_fire_unload) override; 301 bool* proceed_to_fire_unload) override;
306 content::KeyboardEventProcessingResult PreHandleKeyboardEvent( 302 content::KeyboardEventProcessingResult PreHandleKeyboardEvent(
307 content::WebContents* source, 303 content::WebContents* source,
308 const content::NativeWebKeyboardEvent& event) override; 304 const content::NativeWebKeyboardEvent& event) override;
309 void HandleKeyboardEvent( 305 void HandleKeyboardEvent(
310 content::WebContents* source, 306 content::WebContents* source,
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 370
375 base::TimeTicks inspect_element_start_time_; 371 base::TimeTicks inspect_element_start_time_;
376 std::unique_ptr<DevToolsEventForwarder> event_forwarder_; 372 std::unique_ptr<DevToolsEventForwarder> event_forwarder_;
377 std::unique_ptr<DevToolsEyeDropper> eye_dropper_; 373 std::unique_ptr<DevToolsEyeDropper> eye_dropper_;
378 374
379 friend class DevToolsEventForwarder; 375 friend class DevToolsEventForwarder;
380 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 376 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
381 }; 377 };
382 378
383 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 379 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/tab_web_contents_delegate_android.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698