Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: tests/compiler/dart2js/equivalence/check_functions.dart

Issue 2983483002: Check function type equivalence (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/equivalence/check_functions.dart
diff --git a/tests/compiler/dart2js/equivalence/check_functions.dart b/tests/compiler/dart2js/equivalence/check_functions.dart
index 995030f64bdfb156c5009276c523388a5f044433..932f9734cb59cdda55a23ef4f3ef68d5d69f6090 100644
--- a/tests/compiler/dart2js/equivalence/check_functions.dart
+++ b/tests/compiler/dart2js/equivalence/check_functions.dart
@@ -469,13 +469,10 @@ checkElementEnvironment(
env2.getMemberMetadata(member2),
strategy.testConstantValues);
- // TODO(johnniwinther): Check function type. Currently hitting problems with
- // return types of generative constructors, function types referring to
- // typedefs and forwarding constructors.
- /*if (member1 is FunctionEntity && member2 is FunctionEntity) {
+ if (member1 is FunctionEntity && member2 is FunctionEntity) {
check(member1, member2, 'getFunctionType', env1.getFunctionType(member1),
env2.getFunctionType(member2), strategy.typeEquivalence);
- }*/
+ }
}
checkSetEquivalence(env1, env2, 'libraries', env1.libraries, env2.libraries,
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution_strategy.dart ('k') | tests/compiler/dart2js/kernel/test_helpers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698