ios/web_view/internal/translate/cwv_translation_configuration_internal.h - Issue 2983453002: Expose way to enable/disable translate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web_view/internal/translate/cwv_translation_configuration_internal.h

Issue 2983453002: Expose way to enable/disable translate. (Closed)

Patch Set: Refactor settings Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/web_view/internal/translate/cwv_translation_configuration.mm ('K') | « ios/web_view/internal/translate/cwv_translation_configuration.mm ('k') | ios/web_view/internal/translate/cwv_translation_controller.mm » ('j') | ios/web_view/internal/web_view_web_main_delegate.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_VIEW_INTERNAL_TRANSLATE_CWV_TRANSLATION_CONFIGURATION_H_

	6 #define IOS_WEB_VIEW_INTERNAL_TRANSLATE_CWV_TRANSLATION_CONFIGURATION_H_

	7

	8 #import "ios/web_view/public/cwv_translation_configuration.h"

	9

	10 class PrefService;

	11

	12 // Internal methods to hide C++ details.
	Eugene But (OOO till 7-30) 2017/07/14 00:22:43 nit: Do we need this comment? Technically category nit: Do we need this comment? Technically category does not exist to hide C++ details, but to hide private initializer. jzw1 2017/07/14 02:09:49 Done. Show quoted text On 2017/07/14 00:22:43, Eugene But wrote: > nit: Do we need this comment? Technically category does not exist to hide C++ > details, but to hide private initializer. Done.
	13 @interface CWVTranslationConfiguration ()

	14

	15 // Takes a PrefService object used to modify settings.
	Eugene But (OOO till 7-30) 2017/07/14 00:22:43 Please document that callers are responsible for k Please document that callers are responsible for keeping \|prefService\| alive until CWVTranslationConfiguration is alive. jzw1 2017/07/14 02:09:49 Done. Show quoted text On 2017/07/14 00:22:43, Eugene But wrote: > Please document that callers are responsible for keeping \|prefService\| alive > until CWVTranslationConfiguration is alive. Done.
	16 - (instancetype)initWithPrefService:(PrefService*)prefService

	17 NS_DESIGNATED_INITIALIZER;

	18

	19 @end

	20

	21 #endif // IOS_WEB_VIEW_INTERNAL_TRANSLATE_CWV_TRANSLATION_CONFIGURATION_H_

OLD	NEW