Resynthesize constructor initializers from Kernel.

Resynthesize constructor initializers from Kernel.

We don't resynthesize assert initializers yet, because they are
compiled into an unholy mess.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e0658b18a3b294da4c718af91ef970764decda1d

[scheglov, 2017-07-24 22:40:41]

Description was changed from

==========
Resynthesize constructor initializers from Kernel.

We don't resynthesize assert initializers yet, because they are
compiled into an unholy mess.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=
==========

to

==========
Resynthesize constructor initializers from Kernel.

We don't resynthesize assert initializers yet, because they are
compiled into an unholy mess.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=
==========

[scheglov, 2017-07-24 22:40:42]

scheglov@google.com changed reviewers:
+ kmillikin@google.com

[Brian Wilkerson, 2017-07-25 15:13:02]

lgtm

[Siggi Cherem (dart-lang), 2017-07-25 15:19:56]

changes to FE & kernel also LGTM

https://codereview.chromium.org/2983413002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart (right):

https://codereview.chromium.org/2983413002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart:2119: class
_KernelLibraryResynthesizerContextImpl
question unrelated to the CL: what is your plan with this context class later
on? Is the plan to move it out of this test file into the lib dir eventually? To
implement it based on ast_builder? Or something else?

[Siggi Cherem (dart-lang), 2017-07-25 15:21:36]

I should note: because I'm not as familiar with all the internal workings of the
body_builder, I would like Peter or Paul to also take a glance when they are
back next week just in case, but I think it is ok to submit and revise later if
they have any additional comments.

[scheglov, 2017-07-25 16:15:54]

https://codereview.chromium.org/2983413002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart (right):

https://codereview.chromium.org/2983413002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart:2119: class
_KernelLibraryResynthesizerContextImpl
On 2017/07/25 15:19:56, Siggi Cherem (dart-lang) wrote:
> question unrelated to the CL: what is your plan with this context class later
> on? Is the plan to move it out of this test file into the lib dir eventually?
To
> implement it based on ast_builder? Or something else?
>  

Yes, the plan is to extract these classes into a separate file in analyzer/lib.

[scheglov, 2017-07-25 16:24:01]

Description was changed from

==========
Resynthesize constructor initializers from Kernel.

We don't resynthesize assert initializers yet, because they are
compiled into an unholy mess.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=
==========

to

==========
Resynthesize constructor initializers from Kernel.

We don't resynthesize assert initializers yet, because they are
compiled into an unholy mess.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e0658b18a3b294da4c718af91ef970764decda1d
==========

[scheglov, 2017-07-25 16:24:03]

Committed patchset #1 (id:1) manually as
e0658b18a3b294da4c718af91ef970764decda1d (presubmit successful).