Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2983403003: Fix DDC travis status (Closed)

Created:
3 years, 5 months ago by vsm
Modified:
3 years, 5 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix DDC travis status A few more passes, but perhaps one regression: Chrome 59.0.3071 (Mac OS X 10.12.5) corelib/date_time10_test FAILED Error: Expect.equals(at index 1: Expected <0100-01-01 00:00:00.000Z...>, Found: <0099-01-01 00:00:00.000Z...>) fails. at finish (test/browser/language_tests.js:807:59) TBR=rnystrom@google.com,jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/598b98bd09173e88c231e9e6684c8184758cdafa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/compile_error_tests.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
Committed patchset #1 (id:1) manually as 598b98bd09173e88c231e9e6684c8184758cdafa (presubmit successful).
3 years, 5 months ago (2017-07-25 15:36:34 UTC) #2
Jennifer Messerly
lgtm! also fyi, I'm working on removing DDC's copies of status files
3 years, 5 months ago (2017-07-25 17:10:31 UTC) #3
Bob Nystrom
3 years, 5 months ago (2017-07-25 17:37:49 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698