Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2983403002: Reland "Remove fields from Isolate in Product mode" (Closed)

Created:
3 years, 5 months ago by zra
Modified:
3 years, 5 months ago
Reviewers:
danunez, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland "Remove fields from Isolate in Product mode" In my reordering of the fields in Isolate, I omitted the initialization of a few fields in the constroctor. This CL will reland the change with the initialization added back. R=danunez@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8d6bc876f0eddb3cb248e112f4684616be82542c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -133 lines) Patch
M runtime/vm/block_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/heap_test.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/isolate.h View 15 chunks +90 lines, -69 lines 0 comments Download
M runtime/vm/isolate.cc View 23 chunks +70 lines, -53 lines 0 comments Download
M runtime/vm/metrics.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/pages.cc View 6 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/scavenger.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 5 months ago (2017-07-24 22:06:14 UTC) #2
danunez
lgtm
3 years, 5 months ago (2017-07-24 22:15:26 UTC) #3
rmacnak
lgtm
3 years, 5 months ago (2017-07-24 22:28:01 UTC) #4
zra
3 years, 5 months ago (2017-07-25 20:24:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d6bc876f0eddb3cb248e112f4684616be82542c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698