Migrated test block 26 to Dart 2.0.

Migrated test block 26 to Dart 2.0.

Simple block. Updated two lines in splay_tree_test to expect
compile-time errors and updated status files accordingly.

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/edfb6d02bfd69a9ad8867fe9e401414da246d2cb

[bkonyi, 2017-07-24 20:55:38]

bkonyi@google.com changed reviewers:
+ jcollins@google.com, rnystrom@google.com

[Bob Nystrom, 2017-07-24 22:27:43]

The checked mode stuff will need a little more manual attention. After that,
LGTM!

https://codereview.chromium.org/2983383002/diff/20001/tests/corelib_2/splay_t...
File tests/corelib_2/splay_tree_from_iterable_test.dart (right):

https://codereview.chromium.org/2983383002/diff/20001/tests/corelib_2/splay_t...
tests/corelib_2/splay_tree_from_iterable_test.dart:129: if (!isCheckedMode)
return;
Dart 2.0 doesn't have checked mode anymore (or, perhaps more accurately, it
doesn't have *unchecked* mode), so you'll want to remove this check and always
execute these tests.

In many cases, the checked mode tests will end up getting deleted because the
code under test also has a static error so there is no runtime behavior in
strong mode. SplayTreeMap.fromIterable() is a little different because it isn't
as fully-typed as we'd like — it takes an Iterable<dynamic> instead of a more
precisely typed iterable. That means the type checks do happen at runtime, so I
think these tests are valid.

https://codereview.chromium.org/2983383002/diff/20001/tests/corelib_2/splay_t...
File tests/corelib_2/splay_tree_test.dart (right):

https://codereview.chromium.org/2983383002/diff/20001/tests/corelib_2/splay_t...
tests/corelib_2/splay_tree_test.dart:129: map["string"] = 42; //# 02:
compile-time error
Nice.

[bkonyi, 2017-07-25 18:22:26]

I've updated the splay_tree_from_iterables_test to address your previous
comments @rnystrom. PTAQL before I land to make sure this is what you meant.

[Bob Nystrom, 2017-07-25 22:37:49]

LGTM! :)

[bkonyi, 2017-07-25 23:36:45]

Description was changed from

==========
Migrated test block 26 to Dart 2.0.

Simple block. Updated two lines in splay_tree_test to expect
compile-time errors and updated status files accordingly.

BUG=
==========

to

==========
Migrated test block 26 to Dart 2.0.

Simple block. Updated two lines in splay_tree_test to expect
compile-time errors and updated status files accordingly.

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/edfb6d02bfd69a9ad8867fe9e401414da246d2cb
==========

[bkonyi, 2017-07-25 23:36:47]

Committed patchset #3 (id:40001) manually as
edfb6d02bfd69a9ad8867fe9e401414da246d2cb.