Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: trunk/src/build/common.gypi

Issue 298333007: Revert 273199 "Enable mac_strip_release under ASan on OSX. Remov..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/build/asan.saves ('k') | trunk/src/chrome/app/app_asan.saves » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/common.gypi
===================================================================
--- trunk/src/build/common.gypi (revision 273301)
+++ trunk/src/build/common.gypi (working copy)
@@ -2018,8 +2018,9 @@
'use_allocator%': 'none',
}],
['asan==1 and OS=="mac"', {
- # Strip and produce the .dSYM files.
- 'mac_strip_release': 1,
+ # TODO(glider): we do not strip ASan binaries until the dynamic ASan
+ # runtime is fully adopted. See http://crbug.com/242503.
+ 'mac_strip_release': 0,
}],
['lsan==1', {
'clang%': 1,
@@ -4689,6 +4690,16 @@
],
},
],
+ 'conditions': [
+ ['asan==1', {
+ 'variables': {
+ 'asan_saves_file': 'asan.saves',
+ },
+ 'xcode_settings': {
+ 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)',
+ },
+ }],
+ ],
'target_conditions': [
['mac_pie==1 and release_valgrind_build==0', {
# Turn on position-independence (ASLR) for executables. When
@@ -4728,6 +4739,13 @@
# additional flags are added with STRIPFLAGS.
'STRIPFLAGS': '-x',
}], # _type=="shared_library" or _type=="loadable_module"
+ ['_type=="executable"', {
+ 'conditions': [
+ ['asan==1', {
+ 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
+ }]
+ ],
+ }], # _type=="executable" and asan==1
], # target_conditions
}, # xcode_settings
}, # configuration "Release"
« no previous file with comments | « trunk/src/build/asan.saves ('k') | trunk/src/chrome/app/app_asan.saves » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698