DescriptionRevert 273199 "Enable mac_strip_release under ASan on OSX. Remov..."
Seems causing failures on mac asan bots, e.g:
http://build.chromium.org/p/chromium.memory/waterfall?builder=Mac%20ASan%2064%20Tests%20(1)
> Enable mac_strip_release under ASan on OSX. Remove the .saves files.
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions.
> This CL deletes the .saves files and turns mac_strip_release on for ASan
> builds.
>
> BUG=148383, 242503, 170739, 166857
> R=mark@chromium.org
>
> Review URL: https://codereview.chromium.org/292153006
TBR=glider@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273302
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|