Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 298333007: Revert 273199 "Enable mac_strip_release under ASan on OSX. Remov..." (Closed)

Created:
6 years, 6 months ago by Ronghua Wu (Left Chromium)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273199 "Enable mac_strip_release under ASan on OSX. Remov..." Seems causing failures on mac asan bots, e.g: http://build.chromium.org/p/chromium.memory/waterfall?builder=Mac%20ASan%2064%20Tests%20(1) > Enable mac_strip_release under ASan on OSX. Remove the .saves files. > > Unce upon a time the ASan runtime library used to be statically linked into > the executables on OSX. > Because that library provided a number of API functions needed by the shared > libraries, we had custom ASan-specific .saves files that told the `strip` > utility to preserve those functions when stripping the executables. > > Then ASan switched to using dynamic runtime library, which instantly broke the > stripping step, because the executables weren't necessarily referencing all the > ASan API functions (issue 242503). > As a result, stripping has been disabled, and we haven't had .dSYM debug info > for ASan builds for more than a year now (issue 148383). > > Because the ASan API functions are now undefined in the executables, it's > actually senseless to use the .saves files to preserve those functions. > This CL deletes the .saves files and turns mac_strip_release on for ASan > builds. > > BUG=148383, 242503, 170739, 166857 > R=mark@chromium.org > > Review URL: https://codereview.chromium.org/292153006 TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A + trunk/src/build/asan.saves View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/build/common.gypi View 3 chunks +20 lines, -2 lines 0 comments Download
A + trunk/src/chrome/app/app_asan.saves View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/chrome.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_exe.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ronghua Wu (Left Chromium)
6 years, 6 months ago (2014-05-28 18:48:23 UTC) #1
Ronghua Wu (Left Chromium)
6 years, 6 months ago (2014-05-28 18:48:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273302 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698