Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Implement a common MessageSink Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/devtools/front_end/sdk/TimelineManager.js ('K') | « Source/devtools/front_end/sdk/TimelineManager.js ('k') | Source/devtools/front_end/sources/UISourceCodeFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/Source/devtools/front_end/sources/SourcesPanel.js b/Source/devtools/front_end/sources/SourcesPanel.js
index 1798dbaaf643ad7752f149ef05955602e9002def..679b3c7e159b22a9b3ef11460fab0e34cc3a25af 100644
--- a/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/Source/devtools/front_end/sources/SourcesPanel.js
@@ -983,7 +983,8 @@ WebInspector.SourcesPanel.prototype = {
message += " " + result.description;
result.release();
}
- target.consoleModel.showErrorMessage(message)
+ // FIXME: Make use of target once we have more targets.
sergeyv 2014/05/29 12:44:06 We shouldn't change it
apavlov 2014/05/29 13:47:46 Done.
+ WebInspector.messageSink.addErrorMessage(message, true);
}
},
« Source/devtools/front_end/sdk/TimelineManager.js ('K') | « Source/devtools/front_end/sdk/TimelineManager.js ('k') | Source/devtools/front_end/sources/UISourceCodeFrame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698