Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2121)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/devtools/front_end/sdk/IsolatedFileSystemManager.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Implement a common MessageSink Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/devtools/front_end/sdk/ConsoleModel.js ('K') | « Source/devtools/front_end/sdk/ConsoleModel.js ('k') | Source/devtools/front_end/sdk/LiveEditSupport.js » ('j') | Source/devtools/front_end/sdk/SASSSourceMapping.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/IsolatedFileSystemManager.js
diff --git a/Source/devtools/front_end/sdk/IsolatedFileSystemManager.js b/Source/devtools/front_end/sdk/IsolatedFileSystemManager.js
index e3cd0388affa84220bd1ea5f74cd7bc0c0b643b2..d8cdfc3d190b79481a91edcb3ae53b6b31faa56a 100644
--- a/Source/devtools/front_end/sdk/IsolatedFileSystemManager.js
+++ b/Source/devtools/front_end/sdk/IsolatedFileSystemManager.js
@@ -128,9 +128,9 @@ WebInspector.IsolatedFileSystemManager.prototype = {
_fileSystemAdded: function(errorMessage, fileSystem)
{
var fileSystemPath;
- if (errorMessage)
- WebInspector.console.showErrorMessage(errorMessage)
- else if (fileSystem) {
+ if (errorMessage) {
+ WebInspector.messageSink.addErrorMessage(errorMessage, true);
+ } else {
this._innerAddFileSystem(fileSystem);
fileSystemPath = fileSystem.fileSystemPath;
}
« Source/devtools/front_end/sdk/ConsoleModel.js ('K') | « Source/devtools/front_end/sdk/ConsoleModel.js ('k') | Source/devtools/front_end/sdk/LiveEditSupport.js » ('j') | Source/devtools/front_end/sdk/SASSSourceMapping.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698