Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2101)

Unified Diff: Source/devtools/front_end/sdk/CompilerScriptMapping.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Implement a common MessageSink Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/CompilerScriptMapping.js
diff --git a/Source/devtools/front_end/sdk/CompilerScriptMapping.js b/Source/devtools/front_end/sdk/CompilerScriptMapping.js
index 141cf63b90c5814e921f90945b0453f1908cc696..47432498911831f4b8d0637d3f1c0d37e82323e6 100644
--- a/Source/devtools/front_end/sdk/CompilerScriptMapping.js
+++ b/Source/devtools/front_end/sdk/CompilerScriptMapping.js
@@ -134,10 +134,12 @@ WebInspector.CompilerScriptMapping.prototype = {
this._networkWorkspaceBinding.addFileForURL(sourceURL, contentProvider, script.isContentScript());
}
var uiSourceCode = this._workspace.uiSourceCodeForURL(sourceURL);
- if (uiSourceCode)
+ if (uiSourceCode) {
this._bindUISourceCode(uiSourceCode);
- else
- this._target.consoleModel.showErrorMessage(WebInspector.UIString("Failed to locate workspace file mapped to URL %s from source map %s", sourceURL, sourceMap.url()));
+ } else {
+ // FIXME: Make use of this._target once we have more targets.
+ WebInspector.messageSink.addErrorMessage(WebInspector.UIString("Failed to locate workspace file mapped to URL %s from source map %s", sourceURL, sourceMap.url()), true);
+ }
}
script.updateLocations();
}

Powered by Google App Engine
This is Rietveld 408576698