Source/devtools/front_end/elements/MetricsSidebarPane.js - Issue 298333003: DevTools: Implement console message logging through an extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Implement a common MessageSink Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | Source/devtools/front_end/inspector.html » ('j') | Source/devtools/front_end/sdk/ConsoleModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/elements/MetricsSidebarPane.js

diff --git a/Source/devtools/front_end/elements/MetricsSidebarPane.js b/Source/devtools/front_end/elements/MetricsSidebarPane.js

index c31a7acc50fb4633f2a72e5d6b3a051b6c4007ea..2bbdddbd74df62e84bbb87aa9237770a57cc2a69 100644

--- a/Source/devtools/front_end/elements/MetricsSidebarPane.js

+++ b/Source/devtools/front_end/elements/MetricsSidebarPane.js

@@ -433,7 +433,7 @@ WebInspector.MetricsSidebarPane.prototype = {

if (computedStyle.getPropertyValue("box-sizing") === "border-box" && (styleProperty === "width" || styleProperty === "height")) {

if (!userInput.match(/px$/)) {

- WebInspector.console.log("For elements with box-sizing: border-box, only absolute content area dimensions can be applied", WebInspector.ConsoleMessage.MessageLevel.Error, true);

+ WebInspector.messageSink.addErrorMessage("For elements with box-sizing: border-box, only absolute content area dimensions can be applied", true);

return;

}