Source/devtools/front_end/common/Settings.js - Issue 298333003: DevTools: Implement console message logging through an extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/common/Settings.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Implement a common MessageSink Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/common/Settings.js

diff --git a/Source/devtools/front_end/common/Settings.js b/Source/devtools/front_end/common/Settings.js

index 126022a6a250f2a4b058ff0b1b7a7463eaa2bc3d..e264cdcf783eddd8dadee50bed16f4944b26e212 100644

--- a/Source/devtools/front_end/common/Settings.js

+++ b/Source/devtools/front_end/common/Settings.js

@@ -283,7 +283,7 @@ WebInspector.BackendSetting.prototype = {

function callback(error)

{

if (error) {

- WebInspector.console.log("Error applying setting " + this._name + ": " + error);

+ WebInspector.messageSink.addErrorMessage("Error applying setting " + this._name + ": " + error);

this._eventSupport.dispatchEventToListeners(this._name, this._value);

return;

}