DevTools: Implement console message logging through an extension

Source/devtools/front_end/sdk/ConsoleModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 100 matching lines @@
             WebInspector.ConsoleMessage.MessageSource.Other,
             messageLevel || WebInspector.ConsoleMessage.MessageLevel.Debug,
             messageText);
 
         this.addMessage(message);
         if (showConsole)
             this.show();
     },
 
     /**
-     * @param {string} error
-     */
-    showErrorMessage: function(error)
-    {
-        this.log(error, WebInspector.ConsoleMessage.MessageLevel.Error, true);
-    },
-
-    /**
      * @param {!WebInspector.ConsoleMessage} msg
      */
     _incrementErrorWarningCount: function(msg)
     {
         switch (msg.level) {
             case WebInspector.ConsoleMessage.MessageLevel.Warning:
                 this.warnings++;
                 break;
             case WebInspector.ConsoleMessage.MessageLevel.Error:
                 this.errors++;
@@ skipping 47 matching lines @@
     }
 
     executionContext.evaluate(text, "console", useCommandLineAPI, false, false, true, printResult.bind(target.consoleModel));
 
     WebInspector.userMetrics.ConsoleEvaluated.record();
 },
 
 
 /**
  * @constructor
- * @extends {WebInspector.TargetAware}
- * @param {!WebInspector.Target} target
+ * @param {?WebInspector.Target} target
  * @param {string} source
  * @param {?string} level
  * @param {string} messageText
  * @param {string=} type
  * @param {?string=} url
  * @param {number=} line
  * @param {number=} column
  * @param {!NetworkAgent.RequestId=} requestId
  * @param {!Array.<!RuntimeAgent.RemoteObject>=} parameters
  * @param {!Array.<!ConsoleAgent.CallFrame>=} stackTrace
  * @param {number=} timestamp
  * @param {boolean=} isOutdated
  * @param {!RuntimeAgent.ExecutionContextId=} executionContextId
  */
 WebInspector.ConsoleMessage = function(target, source, level, messageText, type, url, line, column, requestId, parameters, stackTrace, timestamp, isOutdated, executionContextId)
 {
-    WebInspector.TargetAware.call(this, target);
+    this._target = target;
     this.source = source;
     this.level = level;
     this.messageText = messageText;
     this.type = type || WebInspector.ConsoleMessage.MessageType.Log;
     this.url = url || null;
     this.line = line || 0;
     this.column = column || 0;
     this.parameters = parameters;
     this.stackTrace = stackTrace;
     this.timestamp = timestamp || Date.now();
     this.isOutdated = isOutdated;
     this.executionContextId = executionContextId || 0;
 
     this.request = requestId ? target.networkLog.requestForId(requestId) : null;
 
     if (this.request) {
         this.stackTrace = this.request.initiator.stackTrace;
         if (this.request.initiator && this.request.initiator.url) {
             this.url = this.request.initiator.url;
             this.line = this.request.initiator.lineNumber;
         }
     }
 }
 
 WebInspector.ConsoleMessage.prototype = {
     /**
+     * @return {?WebInspector.Target}
+     */
+    target: function()
+    {
+        return this._target;
+    },
+
+    /**
      * @param {!WebInspector.ConsoleMessage} originatingMessage
      */
     setOriginatingMessage: function(originatingMessage)
     {
         this._originatingConsoleMessage = originatingMessage;
     },
 
     /**
      * @return {?WebInspector.ConsoleMessage}
      */
@@ skipping 86 matching lines @@
 
         return (this.target() === msg.target())
             && (this.source === msg.source)
             && (this.type === msg.type)
             && (this.level === msg.level)
             && (this.line === msg.line)
             && (this.url === msg.url)
             && (this.messageText === msg.messageText)
             && (this.request === msg.request)
             && (this.executionContextId === msg.executionContextId);
-    },
-
-    __proto__: WebInspector.TargetAware.prototype
+    }
 }
 
 // Note: Keep these constants in sync with the ones in Console.h
 /**
  * @enum {string}
  */
 WebInspector.ConsoleMessage.MessageSource = {
     XML: "xml",
     JS: "javascript",
     Network: "network",
     ConsoleAPI: "console-api",
     Storage: "storage",
     AppCache: "appcache",
     Rendering: "rendering",
     CSS: "css",
     Security: "security",
     Other: "other",
     Deprecation: "deprecation"
 }
 
+
+/**
+ * @enum {string}
+ */
+WebInspector.ConsoleMessage.MessageLevel = {

[sergeyv, 2014/05/29 12:44:06]

Why did you move it?

[apavlov, 2014/05/29 13:47:46]

Oops, missed the original location...

+    Log: "log",
+    Info: "info",
+    Warning: "warning",
+    Error: "error",
+    Debug: "debug"
+}
+
 /**
  * @enum {string}
  */
 WebInspector.ConsoleMessage.MessageType = {
     Log: "log",
     Dir: "dir",
     DirXML: "dirxml",
     Table: "table",
     Trace: "trace",
     Clear: "clear",
     StartGroup: "startGroup",
     StartGroupCollapsed: "startGroupCollapsed",
     EndGroup: "endGroup",
     Assert: "assert",
     Result: "result",
     Profile: "profile",
     ProfileEnd: "profileEnd",
     Command: "command"
 }
 
 /**
- * @enum {string}
- */
-WebInspector.ConsoleMessage.MessageLevel = {
-    Log: "log",
-    Info: "info",
-    Warning: "warning",
-    Error: "error",
-    Debug: "debug"
-}
-
-/**
  * @param {!WebInspector.ConsoleMessage} a
  * @param {!WebInspector.ConsoleMessage} b
- * @return number
+ * @return {number}
  */
 WebInspector.ConsoleMessage.timestampComparator = function (a, b)
 {
     return a.timestamp - b.timestamp;
 }
 
 /**
  * @constructor
  * @implements {ConsoleAgent.Dispatcher}
  * @param {!WebInspector.ConsoleModel} console
@@ skipping 38 matching lines @@
     {
         if (!WebInspector.settings.preserveConsoleLog.get())
             this._console.clearMessages();
     }
 }
 
 /**
  * @type {!WebInspector.ConsoleModel}
  */
 WebInspector.console;