Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: Source/devtools/front_end/sources/UISourceCodeFrame.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove duplicate logging Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 if (this._textEditor.isClean()) 117 if (this._textEditor.isClean())
118 this._uiSourceCode.resetWorkingCopy(); 118 this._uiSourceCode.resetWorkingCopy();
119 else 119 else
120 this._uiSourceCode.setWorkingCopyGetter(this._textEditor.text.bind(t his._textEditor)); 120 this._uiSourceCode.setWorkingCopyGetter(this._textEditor.text.bind(t his._textEditor));
121 delete this._muteSourceCodeEvents; 121 delete this._muteSourceCodeEvents;
122 }, 122 },
123 123
124 _didEditContent: function(error) 124 _didEditContent: function(error)
125 { 125 {
126 if (error) { 126 if (error) {
127 WebInspector.console.log(error, WebInspector.ConsoleMessage.MessageL evel.Error, true); 127 WebInspector.messageSink.addErrorMessage(error, true);
128 return; 128 return;
129 } 129 }
130 }, 130 },
131 131
132 /** 132 /**
133 * @param {!WebInspector.Event} event 133 * @param {!WebInspector.Event} event
134 */ 134 */
135 _onWorkingCopyChanged: function(event) 135 _onWorkingCopyChanged: function(event)
136 { 136 {
137 if (this._muteSourceCodeEvents) 137 if (this._muteSourceCodeEvents)
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 181
182 dispose: function() 182 dispose: function()
183 { 183 {
184 WebInspector.settings.textEditorAutocompletion.removeChangeListener(this ._enableAutocompletionIfNeeded, this); 184 WebInspector.settings.textEditorAutocompletion.removeChangeListener(this ._enableAutocompletionIfNeeded, this);
185 this._textEditor.dispose(); 185 this._textEditor.dispose();
186 this.detach(); 186 this.detach();
187 }, 187 },
188 188
189 __proto__: WebInspector.SourceFrame.prototype 189 __proto__: WebInspector.SourceFrame.prototype
190 } 190 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/sources/SourcesPanel.js ('k') | Source/devtools/front_end/timeline/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698