Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: Source/devtools/front_end/common/Settings.js

Issue 298333003: DevTools: Implement console message logging through an extension (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove duplicate logging Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 WebInspector.BackendSetting.prototype = { 276 WebInspector.BackendSetting.prototype = {
277 set: function(value) 277 set: function(value)
278 { 278 {
279 /** 279 /**
280 * @param {?Protocol.Error} error 280 * @param {?Protocol.Error} error
281 * @this {WebInspector.BackendSetting} 281 * @this {WebInspector.BackendSetting}
282 */ 282 */
283 function callback(error) 283 function callback(error)
284 { 284 {
285 if (error) { 285 if (error) {
286 WebInspector.console.log("Error applying setting " + this._name + ": " + error); 286 WebInspector.messageSink.addErrorMessage("Error applying setting " + this._name + ": " + error);
287 this._eventSupport.dispatchEventToListeners(this._name, this._va lue); 287 this._eventSupport.dispatchEventToListeners(this._name, this._va lue);
288 return; 288 return;
289 } 289 }
290 WebInspector.Setting.prototype.set.call(this, value); 290 WebInspector.Setting.prototype.set.call(this, value);
291 } 291 }
292 this._setterCallback(value, callback.bind(this)); 292 this._setterCallback(value, callback.bind(this));
293 }, 293 },
294 294
295 __proto__: WebInspector.Setting.prototype 295 __proto__: WebInspector.Setting.prototype
296 } 296 }
(...skipping 452 matching lines...) Expand 10 before | Expand all | Expand 10 after
749 { 749 {
750 var newValue = this._calculateValue(); 750 var newValue = this._calculateValue();
751 if (newValue === this._value) 751 if (newValue === this._value)
752 return; 752 return;
753 this._value = newValue; 753 this._value = newValue;
754 this._eventSupport.dispatchEventToListeners(this._name, this._value); 754 this._eventSupport.dispatchEventToListeners(this._name, this._value);
755 } 755 }
756 } 756 }
757 757
758 WebInspector.settings.pauseOnExceptionStateString = new WebInspector.PauseOnExce ptionStateSetting(); 758 WebInspector.settings.pauseOnExceptionStateString = new WebInspector.PauseOnExce ptionStateSetting();
OLDNEW
« no previous file with comments | « Source/devtools/front_end/common/MessageSink.js ('k') | Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698