Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2983273002: Migrated test block 28 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 28 to Dart 2.0. Relatively simple block. Split string_replace_test into string_replace_test and string_replace_static test and updated status file to expect MissingCompileTimeError for vm + dart2js BUG= R=jcollins@google.com, rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/370938c4c2b045929062a304af1cd8d5ee6178f9

Patch Set 1 #

Patch Set 2 : Updated status file to fix failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2156 lines) Patch
D tests/corelib/string_fromcharcodes_test.dart View 1 chunk +0 lines, -292 lines 0 comments Download
D tests/corelib/string_operations_with_null_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib/string_pattern_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib/string_replace_all_test.dart View 1 chunk +0 lines, -140 lines 0 comments Download
D tests/corelib/string_replace_dollar_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib/string_replace_test.dart View 1 chunk +0 lines, -227 lines 0 comments Download
D tests/corelib/string_runes_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib/string_source_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib/string_split_test.dart View 1 chunk +0 lines, -135 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 3 chunks +6 lines, -1 line 0 comments Download
A + tests/corelib_2/string_fromcharcodes_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_operations_with_null_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_pattern_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_replace_all_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_replace_dollar_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/corelib_2/string_replace_static_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A + tests/corelib_2/string_replace_test.dart View 4 chunks +0 lines, -27 lines 0 comments Download
A + tests/corelib_2/string_runes_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_source_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/string_split_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/corelib_strong/string_fromcharcodes_test.dart View 1 chunk +0 lines, -292 lines 0 comments Download
D tests/corelib_strong/string_operations_with_null_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib_strong/string_pattern_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib_strong/string_replace_all_test.dart View 1 chunk +0 lines, -140 lines 0 comments Download
D tests/corelib_strong/string_replace_dollar_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib_strong/string_replace_test.dart View 1 chunk +0 lines, -227 lines 0 comments Download
D tests/corelib_strong/string_runes_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib_strong/string_source_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib_strong/string_split_test.dart View 1 chunk +0 lines, -135 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bkonyi
3 years, 5 months ago (2017-07-21 17:47:07 UTC) #2
bkonyi
3 years, 5 months ago (2017-07-21 17:47:08 UTC) #3
jcollins
LGTM, same comment regarding running --checked as with block 29
3 years, 5 months ago (2017-07-21 19:12:32 UTC) #4
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-21 19:55:02 UTC) #5
bkonyi
3 years, 5 months ago (2017-07-24 19:10:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
370938c4c2b045929062a304af1cd8d5ee6178f9.

Powered by Google App Engine
This is Rietveld 408576698