Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: tests/corelib_2/uri_query_test.dart

Issue 2983123002: Migrate test block 30 + corelib portion of block 31 to Dart 2.0. (Closed)
Patch Set: Removed tests from corelib/corelib_strong Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib_2/uri_query_test.dart
diff --git a/tests/corelib_strong/uri_query_test.dart b/tests/corelib_2/uri_query_test.dart
similarity index 87%
rename from tests/corelib_strong/uri_query_test.dart
rename to tests/corelib_2/uri_query_test.dart
index e015cb3245badce6cbbe3b7b62a320449626d4f6..cdd3a943633b5e0ca73cf7d3756f8d8451dc27bb 100644
--- a/tests/corelib_strong/uri_query_test.dart
+++ b/tests/corelib_2/uri_query_test.dart
@@ -100,21 +100,21 @@ void testQueryParameters() {
}
unencoded.writeCharCode(i);
}
- encoded = encoded.toString();
- unencoded = unencoded.toString();
- test("a=$encoded", {"a": unencoded});
- test("a=$encoded&b=$encoded", {"a": unencoded, "b": unencoded});
+ String encodedStr = encoded.toString();
+ String unencodedStr = unencoded.toString();
Bob Nystrom 2017/07/20 00:13:07 "var" for these?
bkonyi 2017/07/20 15:05:50 Done.
+ test("a=$encodedStr", {"a": unencodedStr});
+ test("a=$encodedStr&b=$encodedStr", {"a": unencodedStr, "b": unencodedStr});
var map = new Map();
- map[unencoded] = unencoded;
- test("$encoded=$encoded", map);
- test("$encoded=$allEncoded", map, "$encoded=$encoded");
- test("$allEncoded=$encoded", map, "$encoded=$encoded");
- test("$allEncoded=$allEncoded", map, "$encoded=$encoded");
- map[unencoded] = null;
- test("$encoded", map);
- map[unencoded] = "";
- test("$encoded", map);
+ map[unencodedStr] = unencodedStr;
+ test("$encodedStr=$encodedStr", map);
+ test("$encodedStr=$allEncoded", map, "$encodedStr=$encodedStr");
+ test("$allEncoded=$encodedStr", map, "$encodedStr=$encodedStr");
+ test("$allEncoded=$allEncoded", map, "$encodedStr=$encodedStr");
+ map[unencodedStr] = null;
+ test("$encodedStr", map);
+ map[unencodedStr] = "";
+ test("$encodedStr", map);
}
testInvalidQueryParameters() {
@@ -174,9 +174,9 @@ testQueryParametersImmutableMap() {
}
main() {
- testInvalidArguments();
- testEncodeQueryComponent();
+ //testInvalidArguments();
+ //testEncodeQueryComponent();
testQueryParameters();
- testInvalidQueryParameters();
- testQueryParametersImmutableMap();
+ //testInvalidQueryParameters();
+ //testQueryParametersImmutableMap();
Bob Nystrom 2017/07/20 00:13:07 Oops!
bkonyi 2017/07/20 15:05:49 Oops indeed! For sure thought I had uncommented th
}

Powered by Google App Engine
This is Rietveld 408576698