Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2983123002: Migrate test block 30 + corelib portion of block 31 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate test block 30 + corelib portion of block 31 to Dart 2.0. Minor changes to uri_path_test and uri_query_test, and status file updates. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/4d64b9ee37a13f5bc5aa5b1f750cb414533efec6

Patch Set 1 #

Patch Set 2 : Removed tests from corelib/corelib_strong #

Total comments: 6

Patch Set 3 : Addressed Bob's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4510 lines) Patch
M tests/corelib/corelib.status View 1 chunk +0 lines, -1 line 0 comments Download
D tests/corelib/throw_half_surrogate_pair_test.dart View 1 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib/toInt_test.dart View 1 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib/unicode2_test.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
D tests/corelib/unicode_test.dart View 1 1 chunk +0 lines, -16 lines 0 comments Download
D tests/corelib/uri_base_test.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tests/corelib/uri_example_test.dart View 1 1 chunk +0 lines, -96 lines 0 comments Download
D tests/corelib/uri_file_test.dart View 1 1 chunk +0 lines, -325 lines 0 comments Download
D tests/corelib/uri_http_test.dart View 1 1 chunk +0 lines, -82 lines 0 comments Download
D tests/corelib/uri_ipv4_test.dart View 1 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib/uri_ipv6_test.dart View 1 1 chunk +0 lines, -148 lines 0 comments Download
D tests/corelib/uri_normalize_path_test.dart View 1 1 chunk +0 lines, -59 lines 0 comments Download
D tests/corelib/uri_normalize_test.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
D tests/corelib/uri_parameters_all_test.dart View 1 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib/uri_parse_test.dart View 1 1 chunk +0 lines, -72 lines 0 comments Download
D tests/corelib/uri_path_test.dart View 1 1 chunk +0 lines, -188 lines 0 comments Download
D tests/corelib/uri_query_test.dart View 1 1 chunk +0 lines, -182 lines 0 comments Download
D tests/corelib/uri_scheme_test.dart View 1 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib/uri_test.dart View 1 1 chunk +0 lines, -975 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/corelib_2/throw_half_surrogate_pair_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/toInt_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/type_hashcode_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/unicode2_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/unicode_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_base_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_file_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_http_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_ipv4_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_ipv6_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_normalize_path_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_normalize_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_parameters_all_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_parse_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_path_test.dart View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + tests/corelib_2/uri_query_test.dart View 1 2 1 chunk +13 lines, -13 lines 0 comments Download
A + tests/corelib_2/uri_scheme_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/uri_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/corelib_strong/throw_half_surrogate_pair_test.dart View 1 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib_strong/toInt_test.dart View 1 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib_strong/type_hashcode_test.dart View 1 1 chunk +0 lines, -11 lines 0 comments Download
D tests/corelib_strong/unicode2_test.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
D tests/corelib_strong/unicode_test.dart View 1 1 chunk +0 lines, -16 lines 0 comments Download
D tests/corelib_strong/uri_base_test.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tests/corelib_strong/uri_file_test.dart View 1 1 chunk +0 lines, -324 lines 0 comments Download
D tests/corelib_strong/uri_http_test.dart View 1 1 chunk +0 lines, -82 lines 0 comments Download
D tests/corelib_strong/uri_ipv4_test.dart View 1 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib_strong/uri_ipv6_test.dart View 1 1 chunk +0 lines, -148 lines 0 comments Download
D tests/corelib_strong/uri_normalize_path_test.dart View 1 1 chunk +0 lines, -59 lines 0 comments Download
D tests/corelib_strong/uri_normalize_test.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
D tests/corelib_strong/uri_parameters_all_test.dart View 1 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib_strong/uri_parse_test.dart View 1 1 chunk +0 lines, -72 lines 0 comments Download
D tests/corelib_strong/uri_path_test.dart View 1 1 chunk +0 lines, -188 lines 0 comments Download
D tests/corelib_strong/uri_query_test.dart View 1 1 chunk +0 lines, -182 lines 0 comments Download
D tests/corelib_strong/uri_scheme_test.dart View 1 1 chunk +0 lines, -37 lines 0 comments Download
D tests/corelib_strong/uri_test.dart View 1 1 chunk +0 lines, -642 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bkonyi
3 years, 5 months ago (2017-07-19 22:23:53 UTC) #2
Bob Nystrom
Make to sure uncomment out the tests, then LGTM. https://codereview.chromium.org/2983123002/diff/20001/tests/corelib_2/uri_path_test.dart File tests/corelib_2/uri_path_test.dart (right): https://codereview.chromium.org/2983123002/diff/20001/tests/corelib_2/uri_path_test.dart#newcode92 tests/corelib_2/uri_path_test.dart:92: ...
3 years, 5 months ago (2017-07-20 00:13:07 UTC) #3
bkonyi
https://codereview.chromium.org/2983123002/diff/20001/tests/corelib_2/uri_path_test.dart File tests/corelib_2/uri_path_test.dart (right): https://codereview.chromium.org/2983123002/diff/20001/tests/corelib_2/uri_path_test.dart#newcode92 tests/corelib_2/uri_path_test.dart:92: List<String> pathSegments = ["xxx", "yyy", "zzz"]; On 2017/07/20 00:13:07, ...
3 years, 5 months ago (2017-07-20 15:05:50 UTC) #4
bkonyi
3 years, 5 months ago (2017-07-20 15:07:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
4d64b9ee37a13f5bc5aa5b1f750cb414533efec6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698