chrome/browser/ui/ash/launcher/chrome_launcher_controller.h - Issue 298303002: Add option to install an ephemeral app to ChromeOS shelf context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 298303002: Add option to install an ephemeral app to ChromeOS shelf context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added browser test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/webstore_startup_installer.cc ('K') | « chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc » ('j') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

index e0bdadcce9d73d2e0145d4725a4c563e4ebd9c91..9c448b66be6ad31ecdb41ade70f45879f40513bd 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

@@ -179,6 +179,14 @@ class ChromeLauncherController : public ash::ShelfDelegate,

// be pinned.

bool IsPinnable(ash::ShelfID id) const;

+ // Installs the specified id. Only valid if the id corresponds to an ephemeral

+ // app.

+ void Install(ash::ShelfID id);

+ // Returns true if the specified item can be installed. Only true for

+ // ephemeral apps.

+ bool CanInstall(ash::ShelfID id);

// If there is no shelf item in the shelf for application |app_id|, one

// gets created. The (existing or created) shelf items get then locked

// against a users un-pinning removal.