chrome/browser/ui/ash/launcher/launcher_context_menu.h - Issue 298303002: Add option to install an ephemeral app to ChromeOS shelf context menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu.h

Issue 298303002: Add option to install an ephemeral app to ChromeOS shelf context menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed asargent's review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc ('k') | chrome/browser/ui/ash/launcher/launcher_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/launcher_context_menu.h

diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu.h b/chrome/browser/ui/ash/launcher/launcher_context_menu.h

index 429b6eb41ae2f20ba936baeb16705200ae0998fa..0d11e4b8a38fb972a29cf4493a73ff69add6d8b4 100644

--- a/chrome/browser/ui/ash/launcher/launcher_context_menu.h

+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu.h

@@ -57,6 +57,7 @@ class LauncherContextMenu : public ui::SimpleMenuModel,

virtual base::string16 GetLabelForCommandId(int command_id) const OVERRIDE;

virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;

virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;

+ virtual bool IsCommandIdVisible(int command_id) const OVERRIDE;

virtual bool GetAcceleratorForCommandId(

int command_id,

ui::Accelerator* accelerator) OVERRIDE;

@@ -77,6 +78,7 @@ class LauncherContextMenu : public ui::SimpleMenuModel,

MENU_OPEN_NEW,

MENU_CLOSE,

MENU_PIN,

+ MENU_INSTALL,

LAUNCH_TYPE_PINNED_TAB,

LAUNCH_TYPE_REGULAR_TAB,

LAUNCH_TYPE_FULLSCREEN,