Add option to install an ephemeral app to ChromeOS shelf context menu

chrome/browser/extensions/webstore_install_prompt.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/webstore_install_prompt.h"
+
+#include "chrome/browser/extensions/webstore_installer.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
+#include "content/public/browser/web_contents.h"
+
+using content::WebContents;
+
+namespace extensions {
+
+WebstoreInstallPrompt::WebstoreInstallPrompt(
+    const std::string& webstore_item_id,
+    Profile* profile,
+    const Callback& callback)
+    : WebstoreStandaloneInstaller(webstore_item_id, profile, callback),
+      dummy_web_contents_(
+          WebContents::Create(WebContents::CreateParams(profile))),
+      parent_window_(NULL) {
+  set_install_source(WebstoreInstaller::INSTALL_SOURCE_OTHER);
+}
+
+WebstoreInstallPrompt::WebstoreInstallPrompt(
+    const std::string& webstore_item_id,
+    Profile* profile,
+    gfx::NativeWindow parent_window,
+    const Callback& callback)
+    : WebstoreStandaloneInstaller(webstore_item_id, profile, callback),
+      dummy_web_contents_(
+          WebContents::Create(WebContents::CreateParams(profile))),
+      parent_window_(parent_window) {
+  set_install_source(WebstoreInstaller::INSTALL_SOURCE_OTHER);

[tapted, 2014/05/28 06:28:46]

since it's a separate constructor, maybe DCHECK(parent_window)

(I'd also be fine with getting rid of the 3-arg constructor)

+}
+
+WebstoreInstallPrompt::~WebstoreInstallPrompt() {
+}
+
+bool WebstoreInstallPrompt::CheckRequestorAlive() const {
+  // Assume the requestor is always alive.
+  return true;
+}
+
+const GURL& WebstoreInstallPrompt::GetRequestorURL() const {
+  return dummy_requestor_url_;
+}
+
+scoped_ptr<ExtensionInstallPrompt::Prompt>
+WebstoreInstallPrompt::CreateInstallPrompt() const {
+  scoped_ptr<ExtensionInstallPrompt::Prompt> prompt(
+      new ExtensionInstallPrompt::Prompt(
+          ExtensionInstallPrompt::INSTALL_PROMPT));
+  return prompt.Pass();
+}
+
+scoped_ptr<ExtensionInstallPrompt> WebstoreInstallPrompt::CreateInstallUI() {
+  // Create an ExtensionInstallPrompt with a parent window.
+  if (parent_window_) {
+    return make_scoped_ptr(
+        new ExtensionInstallPrompt(profile(), parent_window_, this));
+  }
+
+  // The WebContents passed to ExtensionInstallPrompt is used to find a parent
+  // window for the dialog. If there is no associated parent native window, pass
+  // NULL so the dialog is placed in the middle of the screen.
+  return make_scoped_ptr(new ExtensionInstallPrompt(NULL));

[tapted, 2014/05/28 06:28:46]

I'm not sure this is safe.. it looks like passing a NULL WebContents will also
result in the profile being NULL, and I'm pretty sure the install UI needs a
profile :).

Note there are comments like

ExtensionInstallUIDefault::ExtensionInstallUIDefault(Profile* profile)
    : ExtensionInstallUI(profile),
      previous_using_system_theme_(false),
      use_app_installed_bubble_(false) {
  // |profile| can be NULL during tests.
  if (profile) {


Which is why it might seem to work..

[edit:] And it looks like the StartupInstaller relied on it..... ick. Maybe that
means it is skipping any install dialogs completely, which might not be good
here.

[tmdiep, 2014/05/28 08:39:27]

Ugh. Using the ExtensionInstallPrompt(content::WebContents*) with NULL does show
a prompt, but I think it has been able to do without it so far.

I changed the call to always use the 3-arg constructor so that profile and
navigator are never NULL. A navigator is required to invoke links, but only
inline install dialogs contain links, so the startup installer has survived so
far without it. The native window arg seems to be only used to parent the window
and can be NULL.

+}
+
+bool WebstoreInstallPrompt::ShouldShowPostInstallUI() const {
+  return false;
+}
+
+bool WebstoreInstallPrompt::ShouldShowAppInstalledBubble() const {
+  return false;
+}
+
+WebContents* WebstoreInstallPrompt::GetWebContents() const {
+  return dummy_web_contents_.get();
+}
+
+bool WebstoreInstallPrompt::CheckInlineInstallPermitted(
+    const base::DictionaryValue& webstore_data,
+    std::string* error) const {
+  // Assume the requestor is trusted.
+  *error = "";

[tapted, 2014/05/28 06:28:46]

nit: "" -> std::string()  (doesn't malloc a 1-byte array)

+  return true;
+}
+
+bool WebstoreInstallPrompt::CheckRequestorPermitted(
+    const base::DictionaryValue& webstore_data,
+    std::string* error) const {
+  // Assume the requestor is trusted.
+  *error = "";

[tapted, 2014/05/28 06:28:46]

std::string()

+  return true;
+}
+
+content::WebContents* WebstoreInstallPrompt::OpenURL(
+    const content::OpenURLParams& params) {
+  chrome::ScopedTabbedBrowserDisplayer displayer(profile(),
+                                                 chrome::GetActiveDesktop());
+  return displayer.browser()->OpenURL(params);
+}
+
+}  // namespace extensions