Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2983013002: Implement optimized mixin application in dart2js (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement optimized mixin application in dart2js This prepares for equivalence testing of shared mixins. Committed: https://github.com/dart-lang/sdk/commit/27a4cbeef92f448ed3b06cd942bb9566669a8f95

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -20 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 4 chunks +223 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 2 chunks +8 lines, -1 line 0 comments Download
A tests/compiler/dart2js/kernel/mixin_test.dart View 1 chunk +201 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/run_from_dill_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-18 14:45:02 UTC) #2
Siggi Cherem (dart-lang)
I didn't get a chance to review the ported algorithm in detail, but I'm OK ...
3 years, 5 months ago (2017-07-19 04:38:35 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 27a4cbeef92f448ed3b06cd942bb9566669a8f95 (presubmit successful).
3 years, 5 months ago (2017-07-19 11:13:58 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-19 11:33:59 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2983013002/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/class_hierarchy.dart (right):

https://codereview.chromium.org/2983013002/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/class_hierarchy.dart:338: /// which is crucial
for memory usage and the Dart VM's bootstrap
On 2017/07/19 04:38:34, Siggi Cherem (dart-lang) wrote:
> VM bootstrap? I just realized this code was ported over from fasta :)?
> 
> Maybe add a comment about it on the first line of this long comment:
> /// The following algorithm is duplicated from fasta/path/to/file.dart
> /// This code will be deleted as soon as we stop testing equivalence of the
old
> and new
> /// compiler models.

Done.

Powered by Google App Engine
This is Rietveld 408576698