Reapply 0489249d29131ed7bf047485c74f557d88eb9974 with a fix for front_end tests.

Reapply 0489249d29131ed7bf047485c74f557d88eb9974 with a fix for front_end tests.

Proper sequencing of _asyncStackTraceHelper in Kernel

This helper function was being called before its argument was
initialized so it was passing null.  Instead, it should be called
after its argument is initialized.

Because the initialization happens in Kernel code, it is simplest to
insert the call explicitly in Kernel code as well as part of the async
transformation.  This has the consequence that we now call the helper
function even when the flag causal_async_stacks is false.

Fixes issue #29771.
Fixes issue #30178
Fixes issue #30058

BUG=
R=aam@google.com, asiva@google.com

Review-Url: https://codereview.chromium.org/2936793003 .
Committed: https://github.com/dart-lang/sdk/commit/c6815e8522f478cb16070042e6e83bb4ed68074a

[Vyacheslav Egorov (Google), 2017-07-17 17:35:05]

Hi Alex, 

Can you check if this fixes the issue with async stack traces for you?

I just fixed the issue with the original code that was causing pkg/front_end
test failures.

If it does solve the issue - lets just land this back.

Cheers,

[aam, 2017-07-17 18:29:47]

On 2017/07/17 17:35:05, Vyacheslav Egorov (Google) wrote:
> Hi Alex, 
> 
> Can you check if this fixes the issue with async stack traces for you?
> 
> I just fixed the issue with the original code that was causing pkg/front_end
> test failures.
> 
> If it does solve the issue - lets just land this back.
> 
> Cheers,

Thanks Slava, just checked - yes it does fix all those problems for me(as in I
can remove -no_causal_async_stacks and run Flutter Gallery app in Debug mode)

[aam, 2017-07-17 18:33:30]

On 2017/07/17 18:29:47, aam wrote:
> On 2017/07/17 17:35:05, Vyacheslav Egorov (Google) wrote:
> > Hi Alex, 
> > 
> > Can you check if this fixes the issue with async stack traces for you?
> > 
> > I just fixed the issue with the original code that was causing pkg/front_end
> > test failures.
> > 
> > If it does solve the issue - lets just land this back.
> > 
> > Cheers,
> 
> Thanks Slava, just checked - yes it does fix all those problems for me(as in I
> can remove -no_causal_async_stacks and run Flutter Gallery app in Debug mode)

lgtm!

[Vyacheslav Egorov (Google), 2017-07-17 18:56:31]

Description was changed from

==========
Reapply 0489249d29131ed7bf047485c74f557d88eb9974 with a fix for front_end tests.

Proper sequencing of _asyncStackTraceHelper in Kernel

This helper function was being called before its argument was
initialized so it was passing null.  Instead, it should be called
after its argument is initialized.

Because the initialization happens in Kernel code, it is simplest to
insert the call explicitly in Kernel code as well as part of the async
transformation.  This has the consequence that we now call the helper
function even when the flag causal_async_stacks is false.

Fixes issue #29771.
Fixes issue #30178
Fixes issue #30058

BUG=
R=aam@google.com, asiva@google.com

Review-Url: https://codereview.chromium.org/2936793003 .
==========

to

==========
Reapply 0489249d29131ed7bf047485c74f557d88eb9974 with a fix for front_end tests.

Proper sequencing of _asyncStackTraceHelper in Kernel

This helper function was being called before its argument was
initialized so it was passing null.  Instead, it should be called
after its argument is initialized.

Because the initialization happens in Kernel code, it is simplest to
insert the call explicitly in Kernel code as well as part of the async
transformation.  This has the consequence that we now call the helper
function even when the flag causal_async_stacks is false.

Fixes issue #29771.
Fixes issue #30178
Fixes issue #30058

BUG=
R=aam@google.com, asiva@google.com

Review-Url: https://codereview.chromium.org/2936793003 .
Committed:
https://github.com/dart-lang/sdk/commit/c6815e8522f478cb16070042e6e83bb4ed68074a
==========

[Vyacheslav Egorov (Google), 2017-07-17 18:56:32]

Committed patchset #2 (id:20001) manually as
c6815e8522f478cb16070042e6e83bb4ed68074a (presubmit successful).