Move resource_devtools_info from webkit/ to content/

Move resource_devtools_info from webkit/ to content/

BUG=338338
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273992

[jam, 2014-05-28 17:41:14]

lgtm with comment

https://codereview.chromium.org/298293010/diff/1/content/common/resource_mess...
File content/common/resource_messages.h (right):

https://codereview.chromium.org/298293010/diff/1/content/common/resource_mess...
content/common/resource_messages.h:31: using content::ResourceDevToolsInfo;
i believe the style guide prohibits using statements in headers. so just preface
it with content:: below

[pilgrim_google, 2014-05-28 17:45:40]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-05-28 17:46:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pilgrim@chromium.org/298293010/20001

[commit-bot: I haz the power, 2014-05-28 22:17:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/10126)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/13212)

[commit-bot: I haz the power, 2014-05-28 22:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 22:26:00]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[pilgrim_google, 2014-05-30 15:29:43]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-05-30 15:31:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pilgrim@chromium.org/298293010/40001

[commit-bot: I haz the power, 2014-05-30 17:33:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-31 02:17:01]

Change committed as 273992

[tfarina, 2014-05-31 03:16:13]

This broke Linux GN in the waterfall:

FAILED: g++ -MMD -MF obj/webkit/common/common.resource_devtools_info.o.d
-DWEBKIT_COMMON_IMPLEMENTATION -DCHROMIUM_BUILD -DENABLE_ONE_CLICK_SIGNIN
-DENABLE_REMOTING=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS
-DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_MOJO=1
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DCLD_VERSION=2
-DENABLE_MDNS=1 -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1
-DENABLE_FULL_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_CAIRO=1
-DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS=1
-DUSE_X11=1 -DUSE_XI2_MT=2 -DENABLE_WEBRTC=1 -D_FILE_OFFSET_BITS=64
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DSK_SUPPORT_LEGACY_GETTOPDEVICE
-DSK_SUPPORT_LEGACY_ASIMAGEINFO -DSK_SUPPORT_LEGACY_N32_NAME
-DSK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALE
-DSK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS -DSK_SUPPORT_LEGACY_IMAGEGENERATORAPI
-DSK_ENABLE_INST_COUNT=0 -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS
-DU_USING_ICU_NAMESPACE=0 "-I../.." "-Igen" "-I/usr/include/glib-2.0"
"-I/usr/lib/x86_64-linux-gnu/glib-2.0/include" "-I../../skia/config"
"-I../../skia/ext" "-I../../third_party/skia/include/config"
"-I../../third_party/skia/include/core"
"-I../../third_party/skia/include/effects"
"-I../../third_party/skia/include/images"
"-I../../third_party/skia/include/lazy"
"-I../../third_party/skia/include/pathops"
"-I../../third_party/skia/include/pdf" "-I../../third_party/skia/include/pipe"
"-I../../third_party/skia/include/ports"
"-I../../third_party/skia/include/utils" "-I../../third_party/skia/src/core"
"-I../../third_party/skia/src/image" "-I../../third_party/skia/src/opts"
"-I../../third_party/skia/src/ports" "-I../../third_party/skia/src/sfnt"
"-I../../third_party/skia/src/utils" "-I../../third_party/skia/src/lazy"
"-I../../third_party/skia/include/gpu" "-I../../third_party/skia/src/gpu"
"-I../../third_party/icu/source/common" "-I../../third_party/icu/source/i18n"
"-I../../third_party/WebKit" "-Igen/ui/resources" "-Igen/webkit" "-Igen/webkit"
-fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64
-funwind-tables -fPIC -pipe -pthread -Wall -Werror -Wsign-compare -Wendif-labels
-Wno-missing-field-initializers -Wno-unused-parameter -fvisibility=hidden
-fno-ident -fdata-sections -ffunction-sections -O2 -g2 -fno-exceptions
-fno-threadsafe-statics -fvisibility-inlines-hidden -fno-rtti -c
../../webkit/common/resource_devtools_info.cc -o
obj/webkit/common/common.resource_devtools_info.o
g++: error: ../../webkit/common/resource_devtools_info.cc: No such file or
directory
g++: fatal error: no input files
compilation terminated.


Not sure how though :/

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20GN&num...

[tfarina, 2014-05-31 03:21:02]

OK, I see.

It is because now we have webkit/common/BUILD.gn which has an entry for
resource_devtools_info.cc.

I'll remove it from there so it should fix this.

[tfarina, 2014-05-31 03:42:33]

OK, fixed in crrev.com/273994