Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2982843003: Reapply "Distinguish between actual closure scopes and non-closure scopes." (Closed)

Created:
3 years, 5 months ago by Emily Fortuna
Modified:
3 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Distinguish between actual closure scopes and non-closure scopes." BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/f8e80ea0a68e2e6f10bcc75b97bcfabd842682e4

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -48 lines) Patch
M pkg/compiler/lib/src/js_model/closure.dart View 1 3 chunks +31 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 5 chunks +42 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Emily Fortuna
The difference being I need to separate out those two maps. I'm going to have ...
3 years, 5 months ago (2017-07-14 20:04:11 UTC) #3
sra1
lgtm https://codereview.chromium.org/2982843003/diff/60001/pkg/compiler/lib/src/js_model/closure.dart File pkg/compiler/lib/src/js_model/closure.dart (right): https://codereview.chromium.org/2982843003/diff/60001/pkg/compiler/lib/src/js_model/closure.dart#newcode153 pkg/compiler/lib/src/js_model/closure.dart:153: // TODO(efortuna): Eventually scopesCapturedInClosureMap[node] should always be non-null, ...
3 years, 5 months ago (2017-07-14 20:42:55 UTC) #6
Emily Fortuna
Committed patchset #2 (id:80001) manually as f8e80ea0a68e2e6f10bcc75b97bcfabd842682e4 (presubmit successful).
3 years, 5 months ago (2017-07-14 21:00:34 UTC) #8
Emily Fortuna
3 years, 5 months ago (2017-07-14 21:01:53 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/2982843003/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/2982843003/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/closure.dart:153: // TODO(efortuna): Eventually
scopesCapturedInClosureMap[node] should always be non-null,
On 2017/07/14 20:42:54, sra1 wrote:
> line length

Done.

Powered by Google App Engine
This is Rietveld 408576698