Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 298283003: Add WasShown/WasHidden to RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on ToT. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/public/renderer/render_frame_observer.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 void SetWebFrame(blink::WebLocalFrame* web_frame); 124 void SetWebFrame(blink::WebLocalFrame* web_frame);
125 125
126 // This method must be called after the frame has been added to the frame 126 // This method must be called after the frame has been added to the frame
127 // tree. It creates all objects that depend on the frame being at its proper 127 // tree. It creates all objects that depend on the frame being at its proper
128 // spot. 128 // spot.
129 void Initialize(); 129 void Initialize();
130 130
131 // Notification from RenderView. 131 // Notification from RenderView.
132 virtual void OnStop(); 132 virtual void OnStop();
133 133
134 // Notifications from RenderWidget.
135 void WasHidden();
136 void WasShown();
137
134 // Start/Stop loading notifications. 138 // Start/Stop loading notifications.
135 // TODO(nasko): Those are page-level methods at this time and come from 139 // TODO(nasko): Those are page-level methods at this time and come from
136 // WebViewClient. We should move them to be WebFrameClient calls and put 140 // WebViewClient. We should move them to be WebFrameClient calls and put
137 // logic in the browser side to balance starts/stops. 141 // logic in the browser side to balance starts/stops.
138 // |to_different_document| will be true unless the load is a fragment 142 // |to_different_document| will be true unless the load is a fragment
139 // navigation, or triggered by history.pushState/replaceState. 143 // navigation, or triggered by history.pushState/replaceState.
140 virtual void didStartLoading(bool to_different_document); 144 virtual void didStartLoading(bool to_different_document);
141 virtual void didStopLoading(); 145 virtual void didStopLoading();
142 virtual void didChangeLoadProgress(double load_progress); 146 virtual void didChangeLoadProgress(double load_progress);
143 147
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 #endif 613 #endif
610 614
611 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 615 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
612 616
613 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 617 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
614 }; 618 };
615 619
616 } // namespace content 620 } // namespace content
617 621
618 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 622 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/public/renderer/render_frame_observer.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698