Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 298283003: Add WasShown/WasHidden to RenderFrameObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add basic test on browser side. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 void SetWebFrame(blink::WebLocalFrame* web_frame); 116 void SetWebFrame(blink::WebLocalFrame* web_frame);
117 117
118 // This method must be called after the frame has been added to the frame 118 // This method must be called after the frame has been added to the frame
119 // tree. It creates all objects that depend on the frame being at its proper 119 // tree. It creates all objects that depend on the frame being at its proper
120 // spot. 120 // spot.
121 void Initialize(); 121 void Initialize();
122 122
123 // Notification from RenderView. 123 // Notification from RenderView.
124 virtual void OnStop(); 124 virtual void OnStop();
125 125
126 // Notifications from RenderWidget.
127 void WasHidden();
128 void WasShown();
129
126 // Start/Stop loading notifications. 130 // Start/Stop loading notifications.
127 // TODO(nasko): Those are page-level methods at this time and come from 131 // TODO(nasko): Those are page-level methods at this time and come from
128 // WebViewClient. We should move them to be WebFrameClient calls and put 132 // WebViewClient. We should move them to be WebFrameClient calls and put
129 // logic in the browser side to balance starts/stops. 133 // logic in the browser side to balance starts/stops.
130 // |to_different_document| will be true unless the load is a fragment 134 // |to_different_document| will be true unless the load is a fragment
131 // navigation, or triggered by history.pushState/replaceState. 135 // navigation, or triggered by history.pushState/replaceState.
132 virtual void didStartLoading(bool to_different_document); 136 virtual void didStartLoading(bool to_different_document);
133 virtual void didStopLoading(); 137 virtual void didStopLoading();
134 virtual void didChangeLoadProgress(double load_progress); 138 virtual void didChangeLoadProgress(double load_progress);
135 139
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
594 blink::WebUserMediaClient* web_user_media_client_; 598 blink::WebUserMediaClient* web_user_media_client_;
595 599
596 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 600 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
597 601
598 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 602 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
599 }; 603 };
600 604
601 } // namespace content 605 } // namespace content
602 606
603 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 607 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698