Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2982803002: Make fasta analyzer happy with dart2js method type change. (Closed)

Created:
3 years, 5 months ago by Emily Fortuna
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make fasta analyzer happy with dart2js method type change. BUG= Committed: https://github.com/dart-lang/sdk/commit/23faeddbef793a42989b74387b3acbd934b595e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
For some reason the dart2js analyze tests didn't catch this... but the bots did! TBR
3 years, 5 months ago (2017-07-13 22:56:48 UTC) #2
Emily Fortuna
Committed patchset #1 (id:1) manually as 23faeddbef793a42989b74387b3acbd934b595e3 (presubmit successful).
3 years, 5 months ago (2017-07-13 22:57:00 UTC) #4
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-13 22:59:50 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698