Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2982753002: Fix bug in Dart API Dart_IntegerToUint64: crash on negative Mints (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug in Dart API Dart_IntegerToUint64: crash on negative Mints R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/1c343d35ac0188e0f7e96f1135e82eb6da7bbe7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 5 months ago (2017-07-13 17:53:57 UTC) #2
zra
lgtm
3 years, 5 months ago (2017-07-13 18:15:29 UTC) #3
alexmarkov
3 years, 5 months ago (2017-07-13 19:19:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c343d35ac0188e0f7e96f1135e82eb6da7bbe7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698