Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2671)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 2982733002: Use entities in most of MirrorsData (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
index 76007aaeda97a5f93f5482a3b476f9537200262f..ee71c76bc0a502b258e8ffd6ba92922c9a7a123f 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
@@ -138,16 +138,7 @@ class Collector {
// multiple times.
for (MemberElement element in _generatedCode.keys) {
if (_mirrorsData.isMemberAccessibleByReflection(element)) {
- bool shouldRetainMetadata =
- _mirrorsData.retainMetadataOfMember(element);
- if (shouldRetainMetadata &&
- (element.isFunction ||
- element.isConstructor ||
- element.isSetter)) {
- MethodElement function = element;
- function.functionSignature.forEachParameter((parameter) =>
- _mirrorsData.retainMetadataOfParameter(parameter));
- }
+ _mirrorsData.retainMetadataOfMember(element);
}
}
for (ClassElement cls in neededClasses) {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/mirrors_data.dart ('k') | pkg/compiler/lib/src/kernel/element_map_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698