Issue 2982733002: Use entities in most of MirrorsData

Issue 2982733002: Use entities in most of MirrorsData (Closed)

Created:
3 years, 5 months ago by Johnni Winther

Modified:
3 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+264 lines, -155 lines)			Patch
M	pkg/compiler/lib/src/common_elements.dart	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/deferred_load.dart	View	1 chunk	+20 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/mirrors_analysis.dart	View	6 chunks	+19 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/mirrors_data.dart	View	18 chunks	+130 lines, -126 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/program_builder/collector.dart	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View	5 chunks	+29 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/kernel/env.dart	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/kernel_strategy.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/resolution_strategy.dart	View	2 chunks	+35 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

lgtm - nice cleanup making the retention of parameters be handled within the retention of ...

3 years, 5 months ago (2017-07-13 19:35:58 UTC) #3

Johnni Winther

3 years, 5 months ago (2017-07-14 09:37:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
996f8ecb5750e65b7cb38be359ddc1138658bffd (presubmit successful).