Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2982713003: Revert "Distinguish between actual closure scopes and non-closure scopes." (Closed)

Created:
3 years, 5 months ago by Emily Fortuna
Modified:
3 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Distinguish between actual closure scopes and non-closure scopes." This reverts commit 6264923aa1308351ab409ead46a749f3c835c3c6. This reverts commit b5ded27c32bb5fc820b0cbea6a52ee5fc2143dbd. This reverts commit 23faeddbef793a42989b74387b3acbd934b595e3. BUG= Committed: https://github.com/dart-lang/sdk/commit/58e5a2393761bfdfe567a9673e4ed598261c9dde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -78 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 3 chunks +20 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 5 chunks +23 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
D-:
3 years, 5 months ago (2017-07-14 00:25:11 UTC) #2
Emily Fortuna
Committed patchset #1 (id:1) manually as 58e5a2393761bfdfe567a9673e4ed598261c9dde (presubmit successful).
3 years, 5 months ago (2017-07-14 00:25:32 UTC) #4
sra1
3 years, 5 months ago (2017-07-14 00:26:17 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698