Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2982713002: Extract interface of InferrerEngine and move implemation to InferrerEngineImpl (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract interface of InferrerEngine and move implemation to InferrerEngineImpl This prepares for parameterizing InferrerEngine and reusing parts for a kernel based inference. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/08f53354733d376b791d9809d18895adf69b9255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -160 lines) Patch
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 16 chunks +208 lines, -159 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-13 13:35:38 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-07-13 22:35:20 UTC) #3
Johnni Winther
3 years, 5 months ago (2017-07-14 08:40:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08f53354733d376b791d9809d18895adf69b9255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698