Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2982673002: Remove deprecated_addError. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing comma. #

Patch Set 3 : Add missing comma. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -23 lines) Patch
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 2 2 chunks +44 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 4 chunks +14 lines, -23 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2980823002 Patch 1

Messages

Total messages: 6 (2 generated)
ahe
3 years, 5 months ago (2017-07-13 09:08:44 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2982673002/diff/1/pkg/front_end/messages.yaml File pkg/front_end/messages.yaml (right): https://codereview.chromium.org/2982673002/diff/1/pkg/front_end/messages.yaml#newcode836 pkg/front_end/messages.yaml:836: template: "The superclass, '#name' has no unnamed constructor ...
3 years, 5 months ago (2017-07-13 09:15:46 UTC) #3
ahe
Thank you, Johnni https://codereview.chromium.org/2982673002/diff/1/pkg/front_end/messages.yaml File pkg/front_end/messages.yaml (right): https://codereview.chromium.org/2982673002/diff/1/pkg/front_end/messages.yaml#newcode836 pkg/front_end/messages.yaml:836: template: "The superclass, '#name' has no ...
3 years, 5 months ago (2017-07-13 12:32:27 UTC) #4
ahe
3 years, 5 months ago (2017-07-13 12:52:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
579a23d8ef2edafba63a917f0c7fad4787d2ee5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698