Battery Status API: add testing support for LayoutTests.

Battery Status API: add testing support for LayoutTests.

Adds plumbing to make it possible to test the blink
implementation of the Battery Status API using LayoutTests and
TestRunner. In test mode a fake battery status dispatcher is
used to allow manual triggering of battery status changes using
TestRunner.didChangeBatteryStatus method.

BUG=122593, 360068
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274652

[jochen (gone - plz use gerrit), 2014-05-28 12:08:17]

https://codereview.chromium.org/298263002/diff/20001/content/renderer/battery...
File content/renderer/battery_status/fake_battery_status_dispatcher.h (right):

https://codereview.chromium.org/298263002/diff/20001/content/renderer/battery...
content/renderer/battery_status/fake_battery_status_dispatcher.h:8: #include
"content/public/renderer/render_process_observer.h"
not needed?

https://codereview.chromium.org/298263002/diff/20001/content/shell/renderer/t...
File content/shell/renderer/test_runner/test_runner.cc (right):

https://codereview.chromium.org/298263002/diff/20001/content/shell/renderer/t...
content/shell/renderer/test_runner/test_runner.cc:872: void
TestRunnerBindings::DidChangeBatteryStatus(gin::Arguments* args) {
you don't need to use gin::Arguments, just use bool charging, double...., and
gin will automatically convert the arguments for you

https://codereview.chromium.org/298263002/diff/20001/content/test/layouttest_...
File content/test/layouttest_support.cc (right):

https://codereview.chromium.org/298263002/diff/20001/content/test/layouttest_...
content/test/layouttest_support.cc:123:
RendererWebKitPlatformSupportImpl::MockBatteryStatusChanged(status);
should the battery status be reset between tests?

[timvolodine, 2014-05-29 08:52:05]

https://codereview.chromium.org/298263002/diff/20001/content/renderer/battery...
File content/renderer/battery_status/fake_battery_status_dispatcher.h (right):

https://codereview.chromium.org/298263002/diff/20001/content/renderer/battery...
content/renderer/battery_status/fake_battery_status_dispatcher.h:8: #include
"content/public/renderer/render_process_observer.h"
On 2014/05/28 12:08:17, jochen wrote:
> not needed?

Done.

https://codereview.chromium.org/298263002/diff/20001/content/shell/renderer/t...
File content/shell/renderer/test_runner/test_runner.cc (right):

https://codereview.chromium.org/298263002/diff/20001/content/shell/renderer/t...
content/shell/renderer/test_runner/test_runner.cc:872: void
TestRunnerBindings::DidChangeBatteryStatus(gin::Arguments* args) {
On 2014/05/28 12:08:17, jochen wrote:
> you don't need to use gin::Arguments, just use bool charging, double...., and
> gin will automatically convert the arguments for you

that's great! done.

https://codereview.chromium.org/298263002/diff/20001/content/test/layouttest_...
File content/test/layouttest_support.cc (right):

https://codereview.chromium.org/298263002/diff/20001/content/test/layouttest_...
content/test/layouttest_support.cc:123:
RendererWebKitPlatformSupportImpl::MockBatteryStatusChanged(status);
On 2014/05/28 12:08:17, jochen wrote:
> should the battery status be reset between tests?

good point, I've added a ResetBatteryStatus method in testRunner for this
purpose.

[timvolodine, 2014-06-02 15:06:47]

On 2014/05/29 08:52:05, timvolodine wrote:
>
https://codereview.chromium.org/298263002/diff/20001/content/renderer/battery...
> File content/renderer/battery_status/fake_battery_status_dispatcher.h (right):
> 
>
https://codereview.chromium.org/298263002/diff/20001/content/renderer/battery...
> content/renderer/battery_status/fake_battery_status_dispatcher.h:8: #include
> "content/public/renderer/render_process_observer.h"
> On 2014/05/28 12:08:17, jochen wrote:
> > not needed?
> 
> Done.
> 
>
https://codereview.chromium.org/298263002/diff/20001/content/shell/renderer/t...
> File content/shell/renderer/test_runner/test_runner.cc (right):
> 
>
https://codereview.chromium.org/298263002/diff/20001/content/shell/renderer/t...
> content/shell/renderer/test_runner/test_runner.cc:872: void
> TestRunnerBindings::DidChangeBatteryStatus(gin::Arguments* args) {
> On 2014/05/28 12:08:17, jochen wrote:
> > you don't need to use gin::Arguments, just use bool charging, double....,
and
> > gin will automatically convert the arguments for you
> 
> that's great! done.
> 
>
https://codereview.chromium.org/298263002/diff/20001/content/test/layouttest_...
> File content/test/layouttest_support.cc (right):
> 
>
https://codereview.chromium.org/298263002/diff/20001/content/test/layouttest_...
> content/test/layouttest_support.cc:123:
> RendererWebKitPlatformSupportImpl::MockBatteryStatusChanged(status);
> On 2014/05/28 12:08:17, jochen wrote:
> > should the battery status be reset between tests?
> 
> good point, I've added a ResetBatteryStatus method in testRunner for this
> purpose.

Jochen, please take another look.

[jochen (gone - plz use gerrit), 2014-06-03 11:20:58]

lgtm

https://codereview.chromium.org/298263002/diff/60001/content/renderer/rendere...
File content/renderer/renderer_webkitplatformsupport_impl.h (right):

https://codereview.chromium.org/298263002/diff/60001/content/renderer/rendere...
content/renderer/renderer_webkitplatformsupport_impl.h:190: static void
MockBatteryStatusChanged(const blink::WebBatteryStatus& status);
nit. add ForTesting() to the name, so presubmit check will catch non-test code
calling this

https://codereview.chromium.org/298263002/diff/60001/content/shell/renderer/t...
File content/shell/renderer/test_runner/test_runner.cc (right):

https://codereview.chromium.org/298263002/diff/60001/content/shell/renderer/t...
content/shell/renderer/test_runner/test_runner.cc:2277: void
TestRunner::ResetBatteryStatus() {
can you call this method from TestRunner::Reset() as well?

[timvolodine, 2014-06-03 15:30:07]

https://codereview.chromium.org/298263002/diff/60001/content/renderer/rendere...
File content/renderer/renderer_webkitplatformsupport_impl.h (right):

https://codereview.chromium.org/298263002/diff/60001/content/renderer/rendere...
content/renderer/renderer_webkitplatformsupport_impl.h:190: static void
MockBatteryStatusChanged(const blink::WebBatteryStatus& status);
On 2014/06/03 11:20:59, jochen wrote:
> nit. add ForTesting() to the name, so presubmit check will catch non-test code
> calling this

Done.

https://codereview.chromium.org/298263002/diff/60001/content/shell/renderer/t...
File content/shell/renderer/test_runner/test_runner.cc (right):

https://codereview.chromium.org/298263002/diff/60001/content/shell/renderer/t...
content/shell/renderer/test_runner/test_runner.cc:2277: void
TestRunner::ResetBatteryStatus() {
On 2014/06/03 11:20:59, jochen wrote:
> can you call this method from TestRunner::Reset() as well?

Done.

[timvolodine, 2014-06-03 18:20:38]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2014-06-03 18:21:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/timvolodine@chromium.org/298263002/80001

[commit-bot: I haz the power, 2014-06-03 22:30:30]

Change committed as 274652