Issue 2982603002: [profiler] Avoid allocating ~2 MB of handles when processing the sample buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2982603002: [profiler] Avoid allocating ~2 MB of handles when processing the sample buffer. (Closed)

Created:
3 years, 5 months ago by rmacnak

Modified:
3 years, 5 months ago

Reviewers:
zra, bkonyi

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[profiler] Avoid allocating ~2 MB of handles when processing the sample buffer. These handles dominated the results of the native allocation profile in hello_world. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/ccb116b5c69ff032dcd2b14dfa14031506ea8427

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	runtime/vm/object.h	View		2 chunks	+2 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 5 months ago (2017-07-12 17:52:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ccb116b5c69ff032dcd2b14dfa14031506ea8427 (presubmit successful).