Rename TranslateUri to UriTranslator, rename files, extract Impl.

Rename TranslateUri to UriTranslator, rename files, extract Impl.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b985f3c00055e49c7a29515ec2159ffb07f62669

[Siggi Cherem (dart-lang), 2017-07-12 17:55:24]

lgtm, some suggestions below

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/uri_translator.dart (right):

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/uri_translator.dart:14: /// with the given
[libraryName], or `null` if there are no patches to apply.
alternatively, we could drop the "or `null`..." and return a const<Uri>[]
instead.

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/uri_translator.dart:25: /// This is the URIs only
transformation, there is no guarantee that the
nit: just to make it easier to read:

"This is the URIs only transformation, ..."
 => 
"Note: this only translates the URI, ...

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/uri_translator_impl.dart (right):

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/uri_translator_impl.dart:57: bool
isPlatformImplementation(Uri uri) {
alternatively, we could move it into UriTranslator and use `extends` instead of
`implements`?

[scheglov, 2017-07-12 18:53:15]

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/uri_translator.dart (right):

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/uri_translator.dart:14: /// with the given
[libraryName], or `null` if there are no patches to apply.
On 2017/07/12 17:55:23, Siggi Cherem (dart-lang) wrote:
> alternatively, we could drop the "or `null`..." and return a const<Uri>[]
> instead.

Yeah, I thought about this.
But then there is TODO in impl class, and if we implement it, we would still
have to return null.

  // TODO(ahe): We probably want this to be `Map<String, Uri>`, that is, just
  // one patch library (with parts).

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/uri_translator.dart:25: /// This is the URIs only
transformation, there is no guarantee that the
On 2017/07/12 17:55:24, Siggi Cherem (dart-lang) wrote:
> nit: just to make it easier to read:
> 
> "This is the URIs only transformation, ..."
>  => 
> "Note: this only translates the URI, ...

Done.

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/uri_translator_impl.dart (right):

https://codereview.chromium.org/2982593002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/uri_translator_impl.dart:57: bool
isPlatformImplementation(Uri uri) {
On 2017/07/12 17:55:24, Siggi Cherem (dart-lang) wrote:
> alternatively, we could move it into UriTranslator and use `extends` instead
of
> `implements`?

Hm... No. If we are to make this method more sophisticated, the source of
information about private platform libraries might be different.

[scheglov, 2017-07-12 18:56:19]

Description was changed from

==========
Rename TranslateUri to UriTranslator, rename files, extract Impl.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Rename TranslateUri to UriTranslator, rename files, extract Impl.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b985f3c00055e49c7a29515ec2159ffb07f62669
==========

[scheglov, 2017-07-12 18:56:23]

Committed patchset #1 (id:1) manually as
b985f3c00055e49c7a29515ec2159ffb07f62669 (presubmit successful).