Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 2982573002: A video tag should not highlight the play button and slider thumb when preload is disabled and not …

Created:
3 years, 5 months ago by George Joseph
Modified:
3 years, 5 months ago
CC:
chrishtr, blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

A video tag should not highlight the play button and slider thumb when preload is disabled and not source is present On a video tag, when preload is set to none, if no src has not been set, the video window play and slider thumb controls be greyed out and minimized respectively. BUG=665149 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
George Joseph
Hello All, I have added a fix for issue 665149. Please do review and let ...
3 years, 5 months ago (2017-07-12 16:53:42 UTC) #3
Stephen White
I'm not the correct person to review this. cc'ed +chrishtr@ just in case fs@ is ...
3 years, 5 months ago (2017-07-12 17:15:01 UTC) #7
chrishtr
3 years, 5 months ago (2017-07-12 17:32:04 UTC) #9
This CL needs a test.

Powered by Google App Engine
This is Rietveld 408576698