Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: Source/core/editing/MarkupAccumulator.cpp

Issue 298253009: Add iterator object to iterate efficiently over an Element's attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/PresentationAttributeStyle.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/MarkupAccumulator.cpp
diff --git a/Source/core/editing/MarkupAccumulator.cpp b/Source/core/editing/MarkupAccumulator.cpp
index b0d91fd56c46757010032988f38c3304faa2716b..2942db3b428e3c3fb98735b771e6d6230424da05 100644
--- a/Source/core/editing/MarkupAccumulator.cpp
+++ b/Source/core/editing/MarkupAccumulator.cpp
@@ -385,9 +385,10 @@ void MarkupAccumulator::appendElement(StringBuilder& result, Element& element, N
appendOpenTag(result, element, namespaces);
if (element.hasAttributes()) {
- unsigned length = element.attributeCount();
- for (unsigned i = 0; i < length; i++)
- appendAttribute(result, element, element.attributeItem(i), namespaces);
+ AttributeIteratorAccessor attributes = element.attributesIterator();
+ AttributeConstIterator end = attributes.end();
+ for (AttributeConstIterator it = attributes.begin(); it != end; ++it)
+ appendAttribute(result, element, **it, namespaces);
}
// Give an opportunity to subclasses to add their own attributes.
« no previous file with comments | « Source/core/dom/PresentationAttributeStyle.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698