Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: Source/core/css/SelectorChecker.cpp

Issue 298253009: Add iterator object to iterate efficiently over an Element's attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/SelectorChecker.h ('k') | Source/core/dom/DatasetDOMStringMap.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 482 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 493
494 // Synchronize the attribute in case it is lazy-computed. 494 // Synchronize the attribute in case it is lazy-computed.
495 // Currently all lazy properties have a null namespace, so only pass localNa me(). 495 // Currently all lazy properties have a null namespace, so only pass localNa me().
496 element.synchronizeAttribute(selectorAttr.localName()); 496 element.synchronizeAttribute(selectorAttr.localName());
497 497
498 if (!element.hasAttributesWithoutUpdate()) 498 if (!element.hasAttributesWithoutUpdate())
499 return false; 499 return false;
500 500
501 const AtomicString& selectorValue = selector.value(); 501 const AtomicString& selectorValue = selector.value();
502 502
503 unsigned attributeCount = element.attributeCount(); 503 AttributeIteratorAccessor attributes = element.attributesIterator();
504 for (size_t i = 0; i < attributeCount; ++i) { 504 AttributeConstIterator end = attributes.end();
505 const Attribute& attributeItem = element.attributeItem(i); 505 for (AttributeConstIterator it = attributes.begin(); it != end; ++it) {
506 const Attribute& attributeItem = **it;
506 507
507 if (!attributeItem.matches(selectorAttr)) 508 if (!attributeItem.matches(selectorAttr))
508 continue; 509 continue;
509 510
510 if (attributeValueMatches(attributeItem, match, selectorValue, true)) 511 if (attributeValueMatches(attributeItem, match, selectorValue, true))
511 return true; 512 return true;
512 513
513 // Case sensitivity for attribute matching is looser than hasAttribute o r 514 // Case sensitivity for attribute matching is looser than hasAttribute o r
514 // Element::shouldIgnoreAttributeCase() for now. Unclear if that's corre ct. 515 // Element::shouldIgnoreAttributeCase() for now. Unclear if that's corre ct.
515 bool caseSensitive = !element.document().isHTMLDocument() || HTMLDocumen t::isCaseSensitiveAttribute(selectorAttr); 516 bool caseSensitive = !element.document().isHTMLDocument() || HTMLDocumen t::isCaseSensitiveAttribute(selectorAttr);
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 return element.focused() && isFrameFocused(element); 1149 return element.focused() && isFrameFocused(element);
1149 } 1150 }
1150 1151
1151 template 1152 template
1152 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const; 1153 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const;
1153 1154
1154 template 1155 template
1155 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const; 1156 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const;
1156 1157
1157 } 1158 }
OLDNEW
« no previous file with comments | « Source/core/css/SelectorChecker.h ('k') | Source/core/dom/DatasetDOMStringMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698