Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298253005: Move geometry to mojo/services, extract input events to their own mojom (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -220 lines) Patch
M mojo/aura/window_tree_host_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/geometry/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/geometry/geometry_type_converters.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/geometry/geometry_type_converters.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/geometry/mojo_geometry_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/mojo_public.gypi View 1 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 chunks +53 lines, -0 lines 0 comments Download
D mojo/public/interfaces/geometry/geometry.mojom View 1 chunk +0 lines, -22 lines 0 comments Download
M mojo/services/native_viewport/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport.mojom View 1 chunk +2 lines, -19 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/public/cpp/geometry/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/public/cpp/geometry/geometry_type_converters.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/public/cpp/geometry/lib/geometry_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/public/cpp/geometry/mojo_geometry_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/public/interfaces/geometry/geometry.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +27 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Ben Goodger (Google)
6 years, 7 months ago (2014-05-27 21:25:15 UTC) #1
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-27 21:46:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/298253005/1
6 years, 7 months ago (2014-05-27 21:47:54 UTC) #3
sky
LGTM https://codereview.chromium.org/298253005/diff/1/mojo/services/native_viewport/DEPS File mojo/services/native_viewport/DEPS (right): https://codereview.chromium.org/298253005/diff/1/mojo/services/native_viewport/DEPS#newcode2 mojo/services/native_viewport/DEPS:2: "+mojo/services/public/cpp/geometry", nit: sort.
6 years, 7 months ago (2014-05-27 22:52:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 03:07:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 03:48:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157457)
6 years, 7 months ago (2014-05-28 03:48:58 UTC) #7
Ben Goodger (Google)
Committed patchset #1 manually as r273161 (presubmit successful).
6 years, 7 months ago (2014-05-28 05:45:10 UTC) #8
Ben Goodger (Google)
6 years, 6 months ago (2014-05-28 15:47:02 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r273251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698