cleanup: Remove NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED from c/b/apps

cleanup: Remove NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED from c/b/apps
Use ExtensionRegistry instead.

R=kalman@chromium.org
BUG=376293
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273115

[limasdf, 2014-05-27 17:14:23]

when you have time.

[not at google - send to devlin, 2014-05-27 17:40:16]

lgtm

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/ephemera...
File chrome/browser/apps/ephemeral_app_service.cc (right):

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_service.cc:106: DCHECK(extension);
no need for DCHECK

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_service.cc:118: DCHECK(extension);
no need for DCHECK

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/shortcut...
File chrome/browser/apps/shortcut_manager.cc (right):

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/shortcut...
chrome/browser/apps/shortcut_manager.cc:79: registrar_.Add(this,
chrome::NOTIFICATION_EXTENSIONS_READY,
Incidentally you should be able to get rid of this notification like:

ExtensionSystem::Get(profile)->ready()->Post(
    FROM_HERE,
    base::Bind(weak_ptr_factory_.GetWeakPtr(),
               &AppShortcutManager::OnceOffCreateShortcuts));

not in this CL though :) would require adding a WeakPtrFactory too.

[limasdf, 2014-05-27 17:54:06]

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/ephemera...
File chrome/browser/apps/ephemeral_app_service.cc (right):

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_service.cc:106: DCHECK(extension);
On 2014/05/27 17:40:16, kalman wrote:
> no need for DCHECK

Done.

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_service.cc:118: DCHECK(extension);
On 2014/05/27 17:40:16, kalman wrote:
> no need for DCHECK

Done.

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/shortcut...
File chrome/browser/apps/shortcut_manager.cc (right):

https://codereview.chromium.org/298253002/diff/1/chrome/browser/apps/shortcut...
chrome/browser/apps/shortcut_manager.cc:79: registrar_.Add(this,
chrome::NOTIFICATION_EXTENSIONS_READY,
On 2014/05/27 17:40:16, kalman wrote:
> Incidentally you should be able to get rid of this notification like:
> 
> ExtensionSystem::Get(profile)->ready()->Post(
>     FROM_HERE,
>     base::Bind(weak_ptr_factory_.GetWeakPtr(),
>                &AppShortcutManager::OnceOffCreateShortcuts));
> 
> not in this CL though :) would require adding a WeakPtrFactory too.

Thank you for let me know that. :) I'll do it in seperate CL.

[limasdf, 2014-05-27 17:54:20]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-27 17:55:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/298253002/20001

[commit-bot: I haz the power, 2014-05-27 21:49:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-27 22:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 22:49:11]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[limasdf, 2014-05-27 23:33:44]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-27 23:36:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/298253002/20001

[commit-bot: I haz the power, 2014-05-28 00:41:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-28 02:41:37]

Change committed as 273115