Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issue 2982503002: Change imports to clean up irritating warning (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change imports to clean up irritating warning This gets rid of the following messages in the build: patched_dart2js_sdk/lib/_internal/js_runtime/lib/native_typed_data.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'. patched_dart2js_sdk/lib/svg/dart2js/svg_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'. patched_dart2js_sdk/lib/web_audio/dart2js/web_audio_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'. patched_dart2js_sdk/lib/web_gl/dart2js/web_gl_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'. patched_dart2js_sdk/lib/web_sql/dart2js/web_sql_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'. BUG= R=ahe@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8623950864c14de7d02b8b527c4d07804cc5c5c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M sdk/lib/_internal/js_runtime/lib/native_typed_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sra1
3 years, 5 months ago (2017-07-11 22:38:55 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-07-11 23:41:13 UTC) #4
Siggi Cherem (dart-lang)
Note that Peter has a CL that will hide the nits in the build.py, but ...
3 years, 5 months ago (2017-07-11 23:42:04 UTC) #5
ahe
lgtm Thank you! As Siggi mentioned, we will turn these nits off again. However, I ...
3 years, 5 months ago (2017-07-12 09:54:53 UTC) #6
sra1
3 years, 5 months ago (2017-07-12 21:38:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8623950864c14de7d02b8b527c4d07804cc5c5c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698