Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: content/browser/service_worker/service_worker_url_loader_job.cc

Issue 2982363002: Add support for fallback content for the frame. This includes main and subframes. (Closed)
Patch Set: rebase to tip Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/url_loader_request_handler.cc ('k') | content/common/throttling_url_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_url_loader_job.cc
diff --git a/content/browser/service_worker/service_worker_url_loader_job.cc b/content/browser/service_worker/service_worker_url_loader_job.cc
index 5eaf1a2ea282f3ff36be493601c003608b1bb3f3..d8bd064f38651daff242d5e56ae5848aa07e4a70 100644
--- a/content/browser/service_worker/service_worker_url_loader_job.cc
+++ b/content/browser/service_worker/service_worker_url_loader_job.cc
@@ -251,8 +251,10 @@ void ServiceWorkerURLLoaderJob::DidDispatchFetchEvent(
// ServiceWorker, we have to check the security level of the responses.
const net::HttpResponseInfo* main_script_http_info =
version->GetMainScriptHttpResponseInfo();
- DCHECK(main_script_http_info);
- ssl_info_ = main_script_http_info->ssl_info;
+ // TODO(kinuko)
+ // Fix this here.
+ if (main_script_http_info)
+ ssl_info_ = main_script_http_info->ssl_info;
std::move(loader_callback_)
.Run(base::Bind(&ServiceWorkerURLLoaderJob::StartResponse,
« no previous file with comments | « content/browser/loader/url_loader_request_handler.cc ('k') | content/common/throttling_url_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698