content/browser/service_worker/service_worker_controllee_request_handler.cc - Issue 2982363002: Add support for fallback content for the frame. This includes main and subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2982363002: Add support for fallback content for the frame. This includes main and subframes. (Closed)

Patch Set: Address review comments. Add the fallback function as a parameter to LoaderCallback Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/navigation_url_loader_network_service.cc ('K') | « content/browser/loader/url_loader_request_handler.h ('k') | content/browser/service_worker/service_worker_request_handler.cc » ('j') | content/browser/service_worker/service_worker_url_loader_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc

index 8196d4e580ea3bf9dafc766010726301d35801f0..e4f3838532e3e64c0f3cc45e63a35479fa16984c 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc

@@ -202,7 +202,7 @@ void ServiceWorkerControlleeRequestHandler::MaybeCreateLoader(

if (!context_ || !provider_host_) {

// We can't do anything other than to fall back to network.

- std::move(callback).Run(StartLoaderCallback());

+ std::move(callback).Run(StartLoaderCallback(), ResponseFallback());

return;

}