Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2982323002: Implement AstBuilder integration for instance creation expressions. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement AstBuilder integration for instance creation expressions. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f1efb202d145a9fb393390e8327238bc4221cf3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -58 lines) Patch
M pkg/analyzer/lib/src/fasta/resolution_applier.dart View 2 chunks +19 lines, -12 lines 0 comments Download
M pkg/front_end/testcases/ast_builder.status View 13 chunks +3 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-07-20 19:19:53 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-20 19:35:11 UTC) #3
Paul Berry
3 years, 5 months ago (2017-07-20 19:52:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1efb202d145a9fb393390e8327238bc4221cf3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698