third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h - Issue 2982313002: [MarkersIntersectingRange #2.05] Add DocumentMarkerList::FirstMarkerIntersectingRange()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

Issue 2982313002: [MarkersIntersectingRange #2.05] Add DocumentMarkerList::FirstMarkerIntersectingRange() (Closed)

Patch Set: Update comment Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/CompositionMarkerListImpl.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

index b5890004ec5fcf3f2ba745189e4b9f942bd179fc..759ceef94207a16587fea1927317cc447912a498 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

@@ -33,6 +33,11 @@ class CORE_EXPORT DocumentMarkerList

// Returns all markers

virtual const HeapVector<Member<DocumentMarker>>& GetMarkers() const = 0;

+ // Returns the first marker that has non-empty overlap with the range

Xiaocheng 2017/07/20 22:07:27 Oops, didn't notice this one. Could you also chan

+ // [start_offset, end_offset], or null if there is no such marker.

+ virtual DocumentMarker* FirstMarkerIntersectingRange(

+ unsigned start_offset,

+ unsigned end_offset) const = 0;

// Returns markers that have non-empty overlap with the range

// [start_offset, end_offset]

virtual HeapVector<Member<DocumentMarker>> MarkersIntersectingRange(