Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: samples/third_party/todomvc/test/markdone_test.dart

Issue 29823005: fixes to polymer, gets tests back to a stable state (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/third_party/todomvc/test/markdone_test.dart
diff --git a/samples/third_party/todomvc/test/markdone_test.dart b/samples/third_party/todomvc/test/markdone_test.dart
index b9290b6af890f03d39a61572c467454cf625ac3b..e7650ff132d3366933b4bc5bde9de0dfb79d77b0 100644
--- a/samples/third_party/todomvc/test/markdone_test.dart
+++ b/samples/third_party/todomvc/test/markdone_test.dart
@@ -5,6 +5,7 @@
library todomvc.test.markdone_test;
import 'dart:html';
+import 'package:polymer/platform.dart' show endOfMicrotask;
import 'package:polymer/polymer.dart';
import 'package:unittest/unittest.dart';
import 'package:unittest/html_config.dart';
@@ -57,19 +58,20 @@ Node findShadowHost(Node node, ShadowRoot root) {
appModel.todos.add(new Todo('three (checked)')..done = true);
appModel.todos.add(new Todo('four (checked)'));
- performMicrotaskCheckpoint();
- var body = query('body');
+ endOfMicrotask(expectAsync0(() {
+ var body = query('body');
- var label = findWithText(body, 'four (checked)');
- expect(label is LabelElement, isTrue, reason: 'text is in a label: $label');
+ var label = findWithText(body, 'four (checked)');
+ expect(label is LabelElement, isTrue, reason: 'text is in a label: $label');
Siggi Cherem (dart-lang) 2013/10/21 21:07:42 80
Jennifer Messerly 2013/10/21 21:42:56 Done.
- var host = findShadowHost(body, label.parentNode);
- var node = host.parent.query('input');
- expect(node is InputElement, isTrue, reason: 'node is a checkbox');
- expect(node.type, 'checkbox', reason: 'node type is checkbox');
- expect(node.checked, isFalse, reason: 'element is unchecked');
+ var host = findShadowHost(body, label.parentNode);
+ var node = host.parent.query('input');
+ expect(node is InputElement, isTrue, reason: 'node is a checkbox');
+ expect(node.type, 'checkbox', reason: 'node type is checkbox');
+ expect(node.checked, isFalse, reason: 'element is unchecked');
- node.dispatchEvent(new MouseEvent('click', detail: 1));
- expect(node.checked, isTrue, reason: 'element is checked');
+ node.dispatchEvent(new MouseEvent('click', detail: 1));
+ expect(node.checked, isTrue, reason: 'element is checked');
+ }));
});
}

Powered by Google App Engine
This is Rietveld 408576698